From: Masahiro Yamada <masahiroy@kernel.org>
To: linux-kbuild@vger.kernel.org,
Matt Porter <mporter@kernel.crashing.org>,
Alexandre Bounine <alex.bou9@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rapidio: remove choice for enumeration
Date: Tue, 14 May 2024 08:27:50 +0900 [thread overview]
Message-ID: <CAK7LNASKANEH6mCvz-5uUcne_x5+M8bWwOyy7fw6SEY7Oz6bww@mail.gmail.com> (raw)
In-Reply-To: <20240511000953.11181-1-masahiroy@kernel.org>
To: Rapidio maintainers
I applied this to linux-kbuild.
If this change is not OK, please let me know.
On Sat, May 11, 2024 at 9:10 AM Masahiro Yamada <masahiroy@kernel.org> wrote:
>
> This is the last use of the tristate choice.
>
> This choice was introduced a decade ago by commit a11650e11093
> ("rapidio: make enumeration/discovery configurable"). Since then,
> RAPIDIO_ENUM_BASIC has always been the sole member.
>
> There was no need to have this choice block.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
>
> drivers/rapidio/Kconfig | 17 ++---------------
> 1 file changed, 2 insertions(+), 15 deletions(-)
>
> diff --git a/drivers/rapidio/Kconfig b/drivers/rapidio/Kconfig
> index b9f8514909bf..f1d742ac8f7c 100644
> --- a/drivers/rapidio/Kconfig
> +++ b/drivers/rapidio/Kconfig
> @@ -59,26 +59,13 @@ config RAPIDIO_DEBUG
>
> If you are unsure about this, say N here.
>
> -choice
> - prompt "Enumeration method"
> - depends on RAPIDIO
> - default RAPIDIO_ENUM_BASIC
> - help
> - There are different enumeration and discovery mechanisms offered
> - for RapidIO subsystem. You may select single built-in method or
> - or any number of methods to be built as modules.
> - Selecting a built-in method disables use of loadable methods.
> -
> - If unsure, select Basic built-in.
> -
> config RAPIDIO_ENUM_BASIC
> - tristate "Basic"
> + tristate "Basic Enumeration method"
> + depends on RAPIDIO
> help
> This option includes basic RapidIO fabric enumeration and discovery
> mechanism similar to one described in RapidIO specification Annex 1.
>
> -endchoice
> -
> config RAPIDIO_CHMAN
> tristate "RapidIO Channelized Messaging driver"
> depends on RAPIDIO
> --
> 2.40.1
>
--
Best Regards
Masahiro Yamada
prev parent reply other threads:[~2024-05-13 23:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-11 0:09 [PATCH] rapidio: remove choice for enumeration Masahiro Yamada
2024-05-13 23:27 ` Masahiro Yamada [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK7LNASKANEH6mCvz-5uUcne_x5+M8bWwOyy7fw6SEY7Oz6bww@mail.gmail.com \
--to=masahiroy@kernel.org \
--cc=alex.bou9@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mporter@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).