From: Masahiro Yamada <masahiroy@kernel.org>
To: Arnd Bergmann <arnd@kernel.org>
Cc: "Arnd Bergmann" <arnd@arndb.de>,
"Nathan Chancellor" <nathan@kernel.org>,
"Nicolas Schier" <nicolas@fjasle.eu>,
"Pierre-Clément Tosi" <ptosi@google.com>,
"Nick Desaulniers" <ndesaulniers@google.com>,
"Ard Biesheuvel" <ardb@kernel.org>,
"Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [v2] kallsyms: ignore ARMv4 thunks along with others
Date: Thu, 15 Feb 2024 22:45:31 +0900 [thread overview]
Message-ID: <CAK7LNASK7xVc7nEF8wQ-ETwbpr1=UbmPWZbu9acBTXPtKkonmQ@mail.gmail.com> (raw)
In-Reply-To: <20240215083225.3976252-1-arnd@kernel.org>
On Thu, Feb 15, 2024 at 5:32 PM Arnd Bergmann <arnd@kernel.org> wrote:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> lld is now able to build ARMv4 and ARMv4T kernels, which means it can
> generate thunks for those (__ARMv4PILongThunk_*, __ARMv4PILongBXThunk_*)
> that can interfere with kallsyms table generation since they do not get
> ignore like the corresponding ARMv5+ ones are:
>
> Inconsistent kallsyms data
> Try "make KALLSYMS_EXTRA_PASS=1" as a workaround
>
> Replace the hardcoded list of thunk symbols with a more general regex that
> covers this one along with future symbols that follow the same pattern.
>
> Fixes: 5eb6e280432d ("ARM: 9289/1: Allow pre-ARMv5 builds with ld.lld 16.0.0 and newer")
> Fixes: efe6e3068067 ("kallsyms: fix nonconverging kallsyms table with lld")
> Suggested-by: Masahiro Yamada <masahiroy@kernel.org>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> v2: use a regular expression instead of listing each one.
Applied to linux-kbuild/fixes.
Thanks.
> ---
> scripts/mksysmap | 13 ++-----------
> 1 file changed, 2 insertions(+), 11 deletions(-)
>
> diff --git a/scripts/mksysmap b/scripts/mksysmap
> index 9ba1c9da0a40..57ff5656d566 100755
> --- a/scripts/mksysmap
> +++ b/scripts/mksysmap
> @@ -48,17 +48,8 @@ ${NM} -n ${1} | sed >${2} -e "
> / __kvm_nvhe_\\$/d
> / __kvm_nvhe_\.L/d
>
> -# arm64 lld
> -/ __AArch64ADRPThunk_/d
> -
> -# arm lld
> -/ __ARMV5PILongThunk_/d
> -/ __ARMV7PILongThunk_/d
> -/ __ThumbV7PILongThunk_/d
> -
> -# mips lld
> -/ __LA25Thunk_/d
> -/ __microLA25Thunk_/d
> +# lld arm/aarch64/mips thunks
> +/ __[[:alnum:]]*Thunk_/d
>
> # CFI type identifiers
> / __kcfi_typeid_/d
> --
> 2.39.2
>
>
--
Best Regards
Masahiro Yamada
prev parent reply other threads:[~2024-02-15 13:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-15 8:32 [PATCH] [v2] kallsyms: ignore ARMv4 thunks along with others Arnd Bergmann
2024-02-15 9:17 ` Ard Biesheuvel
2024-02-15 13:45 ` Masahiro Yamada [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK7LNASK7xVc7nEF8wQ-ETwbpr1=UbmPWZbu9acBTXPtKkonmQ@mail.gmail.com' \
--to=masahiroy@kernel.org \
--cc=ardb@kernel.org \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=nicolas@fjasle.eu \
--cc=ptosi@google.com \
--cc=rmk+kernel@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).