From: Masahiro Yamada <masahiroy@kernel.org>
To: Thorsten Blum <thorsten.blum@toblux.com>
Cc: Jonathan Corbet <corbet@lwn.net>,
Nathan Chancellor <nathan@kernel.org>,
Nicolas Schier <nicolas@fjasle.eu>,
linux-kbuild@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] docs: kbuild: Kconfig: Fix grammar and formatting
Date: Thu, 15 Feb 2024 06:51:26 +0900 [thread overview]
Message-ID: <CAK7LNAR-3MKPAdBk4L4TboLkktNo486YDiV898VQcUEhPdZ95A@mail.gmail.com> (raw)
In-Reply-To: <20240210152003.861-1-thorsten.blum@toblux.com>
On Sun, Feb 11, 2024 at 12:26 AM Thorsten Blum <thorsten.blum@toblux.com> wrote:
>
> - Remove unnecessary spaces
> - Fix grammar s/to solution/solution/
> - Remove newline to be consistent with other headings
>
> Signed-off-by: Thorsten Blum <thorsten.blum@toblux.com>
> ---
> Documentation/kbuild/Kconfig.recursion-issue-01 | 6 +++---
> Documentation/kbuild/kconfig.rst | 1 -
I dropped the change for Documentation/kbuild/kconfig.rst
because it was already reformatted by a previous patch.
https://lore.kernel.org/linux-kbuild/20240112125830.3753464-1-vegard.nossum@oracle.com/
Applied.
Thanks.
> 2 files changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/kbuild/Kconfig.recursion-issue-01 b/Documentation/kbuild/Kconfig.recursion-issue-01
> index e8877db0461f..ac49836d8ecf 100644
> --- a/Documentation/kbuild/Kconfig.recursion-issue-01
> +++ b/Documentation/kbuild/Kconfig.recursion-issue-01
> @@ -16,13 +16,13 @@
> # that are possible for CORE. So for example if CORE_BELL_A_ADVANCED is 'y',
> # CORE must be 'y' too.
> #
> -# * What influences CORE_BELL_A_ADVANCED ?
> +# * What influences CORE_BELL_A_ADVANCED?
> #
> # As the name implies CORE_BELL_A_ADVANCED is an advanced feature of
> # CORE_BELL_A so naturally it depends on CORE_BELL_A. So if CORE_BELL_A is 'y'
> # we know CORE_BELL_A_ADVANCED can be 'y' too.
> #
> -# * What influences CORE_BELL_A ?
> +# * What influences CORE_BELL_A?
> #
> # CORE_BELL_A depends on CORE, so CORE influences CORE_BELL_A.
> #
> @@ -34,7 +34,7 @@
> # the "recursive dependency detected" error.
> #
> # Reading the Documentation/kbuild/Kconfig.recursion-issue-01 file it may be
> -# obvious that an easy to solution to this problem should just be the removal
> +# obvious that an easy solution to this problem should just be the removal
> # of the "select CORE" from CORE_BELL_A_ADVANCED as that is implicit already
> # since CORE_BELL_A depends on CORE. Recursive dependency issues are not always
> # so trivial to resolve, we provide another example below of practical
> diff --git a/Documentation/kbuild/kconfig.rst b/Documentation/kbuild/kconfig.rst
> index c946eb44bd13..766f9cb518df 100644
> --- a/Documentation/kbuild/kconfig.rst
> +++ b/Documentation/kbuild/kconfig.rst
> @@ -45,7 +45,6 @@ file name to override the default name of ".config".
>
> KCONFIG_DEFCONFIG_LIST
> ----------------------
> -
> This environment variable specifies a list of config files which can be used
> as a base configuration in case the .config does not exist yet. Entries in
> the list are separated with whitespaces to each other, and the first one
> --
> 2.39.2
>
--
Best Regards
Masahiro Yamada
prev parent reply other threads:[~2024-02-14 21:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-10 15:20 [PATCH] docs: kbuild: Kconfig: Fix grammar and formatting Thorsten Blum
2024-02-10 18:02 ` Randy Dunlap
2024-02-14 21:51 ` Masahiro Yamada [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK7LNAR-3MKPAdBk4L4TboLkktNo486YDiV898VQcUEhPdZ95A@mail.gmail.com \
--to=masahiroy@kernel.org \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nathan@kernel.org \
--cc=nicolas@fjasle.eu \
--cc=thorsten.blum@toblux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).