From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Abhinav Kumar <quic_abhinavk@quicinc.com>
Cc: Masahiro Yamada <masahiroy@kernel.org>,
Nathan Chancellor <nathan@kernel.org>,
Nicolas Schier <nicolas@fjasle.eu>,
Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>,
Marijn Suijten <marijn.suijten@somainline.org>,
David Airlie <airlied@gmail.com>,
Daniel Vetter <daniel@ffwll.ch>,
linux-kbuild@vger.kernel.org, linux-arm-msm@vger.kernel.org,
dri-devel@lists.freedesktop.org,
freedreno@lists.freedesktop.org
Subject: Re: [PATCH v4 10/16] drm/msm: generate headers on the fly
Date: Wed, 27 Mar 2024 02:04:15 +0200 [thread overview]
Message-ID: <CAA8EJppGmUPympav=NR1oYTPGs=b-DKs3a_h3oWs8tToLQOK=w@mail.gmail.com> (raw)
In-Reply-To: <8c866d80-f98d-29de-59f5-3055184fa115@quicinc.com>
On Wed, 27 Mar 2024 at 01:49, Abhinav Kumar <quic_abhinavk@quicinc.com> wrote:
>
>
>
> On 3/22/2024 3:57 PM, Dmitry Baryshkov wrote:
> > Generate DRM/MSM headers on the fly during kernel build. This removes a
> > need to push register changes to Mesa with the following manual
> > synchronization step. Existing headers will be removed in the following
> > commits (split away to ease reviews).
> >
>
> This change does two things:
>
> 1) move adreno folder compilation under "adreno-y", move display related
> files compilation undere "msm-display-y", move common files under "msm-y"
>
> 2) changes to generate the header using gen_header.py
>
> Why not split it into two changes?
Basically because there is no difference between object files before
we start moving headers.
>
> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> > ---
> > drivers/gpu/drm/msm/.gitignore | 1 +
> > drivers/gpu/drm/msm/Makefile | 97 +++++++++++++++++++++++++++++++++---------
> > drivers/gpu/drm/msm/msm_drv.c | 3 +-
> > drivers/gpu/drm/msm/msm_gpu.c | 2 +-
> > 4 files changed, 80 insertions(+), 23 deletions(-)
> >
>
> <snip>
>
> Are below two changes related to this patch?
Ack, I'll move it to a separate patch.
>
> > +targets += $(ADRENO_HEADERS) $(DISPLAY_HEADERS)
> > diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c
> > index 97790faffd23..9c33f4e3f822 100644
> > --- a/drivers/gpu/drm/msm/msm_drv.c
> > +++ b/drivers/gpu/drm/msm/msm_drv.c
> > @@ -17,8 +17,9 @@
> >
> > #include "msm_drv.h"
> > #include "msm_debugfs.h"
> > +#include "msm_gem.h"
> > +#include "msm_gpu.h"
> > #include "msm_kms.h"
> > -#include "adreno/adreno_gpu.h"
> >
> > /*
> > * MSM driver version:
> > diff --git a/drivers/gpu/drm/msm/msm_gpu.c b/drivers/gpu/drm/msm/msm_gpu.c
> > index 655002b21b0d..cd185b9636d2 100644
> > --- a/drivers/gpu/drm/msm/msm_gpu.c
> > +++ b/drivers/gpu/drm/msm/msm_gpu.c
> > @@ -11,7 +11,7 @@
> > #include "msm_mmu.h"
> > #include "msm_fence.h"
> > #include "msm_gpu_trace.h"
> > -#include "adreno/adreno_gpu.h"
> > +//#include "adreno/adreno_gpu.h"
>
> you can just drop this line
Ack
>
> >
> > #include <generated/utsrelease.h>
> > #include <linux/string_helpers.h>
> >
--
With best wishes
Dmitry
next prev parent reply other threads:[~2024-03-27 0:04 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-22 22:56 [PATCH v4 00/16] drm/msm: generate register header files Dmitry Baryshkov
2024-03-22 22:56 ` [PATCH v4 01/16] drm/msm/mdp5: add writeback block bases Dmitry Baryshkov
2024-03-26 21:39 ` Abhinav Kumar
2024-03-26 21:52 ` Dmitry Baryshkov
2024-03-26 22:25 ` Abhinav Kumar
2024-03-22 22:56 ` [PATCH v4 02/16] drm/msm/hdmi: drop qfprom.xml.h Dmitry Baryshkov
2024-03-26 21:43 ` Abhinav Kumar
2024-03-22 22:56 ` [PATCH v4 03/16] drm/msm/dsi: drop mmss_cc.xml.h Dmitry Baryshkov
2024-03-26 21:44 ` Abhinav Kumar
2024-03-22 22:56 ` [PATCH v4 04/16] drm/msm: move msm_gpummu.c to adreno/a2xx_gpummu.c Dmitry Baryshkov
2024-03-24 9:52 ` Akhil P Oommen
2024-03-24 11:13 ` Dmitry Baryshkov
2024-03-25 13:34 ` Akhil P Oommen
2024-03-22 22:56 ` [PATCH v4 05/16] drm/msm: import XML display registers database Dmitry Baryshkov
2024-03-22 22:56 ` [PATCH v4 06/16] drm/msm: import A2xx-A4xx " Dmitry Baryshkov
2024-03-22 22:56 ` [PATCH v4 07/16] drm/msm: import A5xx " Dmitry Baryshkov
2024-03-22 22:57 ` [PATCH v4 08/16] drm/msm: import A6xx " Dmitry Baryshkov
2024-03-22 22:57 ` [PATCH v4 09/16] drm/msm: import gen_header.py script from Mesa Dmitry Baryshkov
2024-03-26 22:19 ` Abhinav Kumar
2024-03-26 22:25 ` Dmitry Baryshkov
2024-03-26 22:34 ` Abhinav Kumar
2024-03-27 0:01 ` Dmitry Baryshkov
2024-03-22 22:57 ` [PATCH v4 10/16] drm/msm: generate headers on the fly Dmitry Baryshkov
2024-03-24 10:29 ` Akhil P Oommen
2024-03-24 10:57 ` Dmitry Baryshkov
2024-03-25 13:32 ` Akhil P Oommen
2024-03-25 13:50 ` Dmitry Baryshkov
2024-03-26 23:48 ` Abhinav Kumar
2024-03-27 0:04 ` Dmitry Baryshkov [this message]
2024-03-22 22:57 ` [PATCH v4 11/16] drm/msm: drop display-related headers Dmitry Baryshkov
2024-03-22 22:57 ` [PATCH v4 12/16] drm/msm: drop A2xx and common headers Dmitry Baryshkov
2024-03-22 22:57 ` [PATCH v4 13/16] drm/msm: drop A3xx and A4xx headers Dmitry Baryshkov
2024-03-22 22:57 ` [PATCH v4 14/16] drm/msm: drop A5xx header Dmitry Baryshkov
2024-03-22 22:57 ` [PATCH v4 15/16] drm/msm: drop A6xx GMU header Dmitry Baryshkov
2024-03-22 22:57 ` [PATCH v4 16/16] drm/msm: drop A6xx headers Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAA8EJppGmUPympav=NR1oYTPGs=b-DKs3a_h3oWs8tToLQOK=w@mail.gmail.com' \
--to=dmitry.baryshkov@linaro.org \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=masahiroy@kernel.org \
--cc=nathan@kernel.org \
--cc=nicolas@fjasle.eu \
--cc=quic_abhinavk@quicinc.com \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).