From: Alice Ryhl <aliceryhl@google.com>
To: will@kernel.org
Cc: Jamie.Cunliffe@arm.com, a.hindborg@samsung.com,
alex.gaynor@gmail.com, aliceryhl@google.com, ardb@kernel.org,
benno.lossin@proton.me, bjorn3_gh@protonmail.com,
boqun.feng@gmail.com, broonie@kernel.org,
catalin.marinas@arm.com, gary@garyguo.net,
keescook@chromium.org, kernel@valentinobst.de,
linux-arm-kernel@lists.infradead.org,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
mark.rutland@arm.com, masahiroy@kernel.org, maz@kernel.org,
miguel.ojeda.sandonis@gmail.com, nathan@kernel.org,
ndesaulniers@google.com, nicolas@fjasle.eu, ojeda@kernel.org,
rust-for-linux@vger.kernel.org, samitolvanen@google.com,
wedsonaf@gmail.com
Subject: Re: [PATCH v2] rust: add flags for shadow call stack sanitizer
Date: Tue, 30 Apr 2024 11:09:25 +0000 [thread overview]
Message-ID: <20240430110925.1064685-1-aliceryhl@google.com> (raw)
In-Reply-To: <20240409103120.GA22557@willie-the-truck>
Will Deacon <will@kernel.org> wrote:
> On Tue, Mar 05, 2024 at 01:14:19PM +0100, Miguel Ojeda wrote:
>> Otherwise partially reverting to the `target.json` approach sounds good too.
>>
>> I added the `-Zuse-sync-unwind=n` to the list at
>> https://github.com/Rust-for-Linux/linux/issues/2. Given the default is
>> what we want, I have put it in the "Good to have" section.
>
> I think we have time to do this properly, like we did for the clang
> enablement a few years ago. In hindsight, avoiding hacks for the early
> toolchains back then was a really good idea because it meant we could
> rely on a solid baseline set of compiler features from the start.
>
> So, please can we fix this in rustc and just have SCS dependent on that?
Hi Will,
Just to keep you in the loop, I've posted a PR to make rustc recognize
the reserve-x18 target feature, so that the -Ctarget-feature=+reserve-x18
flag stops emitting a warning.
This should be sufficient for adding support for CONFIG_DYNAMIC_SCS.
You can find it here:
https://github.com/rust-lang/rust/pull/124323
As for non-dynamic SCS, I plan to tackle that after the PR is merged.
See the "Future possibilities" section in the linked PR for more info on
that.
Alice
next prev parent reply other threads:[~2024-04-30 11:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-05 11:58 [PATCH v2] rust: add flags for shadow call stack sanitizer Alice Ryhl
2024-03-05 12:14 ` Miguel Ojeda
2024-04-09 10:31 ` Will Deacon
2024-04-09 15:55 ` Miguel Ojeda
2024-04-30 11:09 ` Alice Ryhl [this message]
2024-03-05 14:13 ` Valentin Obst
2024-03-06 19:15 ` Sami Tolvanen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240430110925.1064685-1-aliceryhl@google.com \
--to=aliceryhl@google.com \
--cc=Jamie.Cunliffe@arm.com \
--cc=a.hindborg@samsung.com \
--cc=alex.gaynor@gmail.com \
--cc=ardb@kernel.org \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=gary@garyguo.net \
--cc=keescook@chromium.org \
--cc=kernel@valentinobst.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=masahiroy@kernel.org \
--cc=maz@kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=nicolas@fjasle.eu \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=samitolvanen@google.com \
--cc=wedsonaf@gmail.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).