Linux-KBuild Archive mirror
 help / color / mirror / Atom feed
From: Masahiro Yamada <masahiroy@kernel.org>
To: linux-kbuild@vger.kernel.org
Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
	Masahiro Yamada <masahiroy@kernel.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Subject: [PATCH 0/2] kconfig: fix an unselectable choice in MIPS again, and make sure it never happens
Date: Sat, 23 Mar 2024 17:50:59 +0900	[thread overview]
Message-ID: <20240323085101.1243814-1-masahiroy@kernel.org> (raw)


The reason is already explained here:

https://lore.kernel.org/linux-kbuild/20240127162309.1026549-1-masahiroy@kernel.org/

Commit 5033ad566016 fixed the issue, but the MIPS maintainer
simultaneously applied commit 101bd58fde10, which introduced
another instance of the same mistake.

I will not ask him to pick up this any more.
That would take two development cycles until this choice structure
is banned. Meantime, MIPS would introduce yet another mistake.

I will apply both to my tree.

The second patch makes it an error to stop this whack-a-mole game.



Masahiro Yamada (2):
  MIPS: move unselectable FIT_IMAGE_FDT_EPM5 out of the "System type"
    choice
  kconfig: do not reparent the menu inside a choice block

 arch/mips/Kconfig        | 18 +++++++++---------
 scripts/kconfig/conf.c   |  5 -----
 scripts/kconfig/lkc.h    |  2 +-
 scripts/kconfig/menu.c   | 22 ++++++++++++++++------
 scripts/kconfig/parser.y |  2 +-
 5 files changed, 27 insertions(+), 22 deletions(-)

-- 
2.40.1


             reply	other threads:[~2024-03-23  8:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-23  8:50 Masahiro Yamada [this message]
2024-03-23  8:51 ` [PATCH 1/2] MIPS: move unselectable FIT_IMAGE_FDT_EPM5 out of the "System type" choice Masahiro Yamada
2024-03-23  8:51 ` [PATCH 2/2] kconfig: do not reparent the menu inside a choice block Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240323085101.1243814-1-masahiroy@kernel.org \
    --to=masahiroy@kernel.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=tsbogend@alpha.franken.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).