From: "Arnd Bergmann" <arnd@arndb.de>
To: "Nathan Chancellor" <nathan@kernel.org>,
"Arnd Bergmann" <arnd@kernel.org>
Cc: "Masahiro Yamada" <masahiroy@kernel.org>,
"Nicolas Schier" <nicolas@fjasle.eu>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev
Subject: Re: [PATCH 1/4] kbuild: turn on -Wextra by default
Date: Tue, 09 Apr 2024 20:42:23 +0200 [thread overview]
Message-ID: <1f2e1994-408a-41d3-9b0b-a08d9478e8b8@app.fastmail.com> (raw)
In-Reply-To: <20240409162521.GB3219862@dev-arch.thelio-3990X>
On Tue, Apr 9, 2024, at 18:25, Nathan Chancellor wrote:
> On Thu, Apr 04, 2024 at 05:16:54PM +0200, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@arndb.de>
>
> I have not done any LLVM builds with this change but if this is going to
> be in -next for a little bit, we should be able to get any regressions
> handled quickly.
>
> I am in favor of more warnings but I am a little nervous this will make
> compiler upgrades (or tracking their mainline) even more difficult. I do
> not have a feeling for how often warnings are added to -Wall and -Wextra
> so this may be unfounded but the kernel's -Werror use complicates this
> in my opinion. I can engage with the clang folks to try and be given a
> heads up when a warning is going to be added to -Wextra, it would be
> good to have someone do something similar for GCC, so that those
> upgrades do not cause something like this change to be rolled back.
My impression is that most new warnings get added to -Wall rather than
-Wextra anyway. If they are added to -Wextra, it's still easy enough
to turn them off individually unless W=1 is set.
> It is easy enough to back out of this if necessary though, so:
>
> Acked-by: Nathan Chancellor <nathan@kernel.org>
Thanks!
Arnd
next prev parent reply other threads:[~2024-04-09 19:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-04 15:16 [PATCH 0/4] Enable more warnings by default Arnd Bergmann
2024-04-04 15:16 ` [PATCH 1/4] kbuild: turn on -Wextra " Arnd Bergmann
2024-04-09 16:25 ` Nathan Chancellor
2024-04-09 18:42 ` Arnd Bergmann [this message]
2024-04-04 15:16 ` [PATCH 2/4] kbuild: remove redundant extra warning flags Arnd Bergmann
2024-04-04 15:16 ` [PATCH 3/4] kbuild: turn on -Wrestrict by default Arnd Bergmann
2024-04-04 15:16 ` [PATCH 4/4] kbuild: enable -Wformat-truncation on clang Arnd Bergmann
2024-04-08 22:00 ` [PATCH 0/4] Enable more warnings by default Justin Stitt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f2e1994-408a-41d3-9b0b-a08d9478e8b8@app.fastmail.com \
--to=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=masahiroy@kernel.org \
--cc=nathan@kernel.org \
--cc=nicolas@fjasle.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).