From: Joerg Roedel <joro@8bytes.org>
To: Vasant Hegde <vasant.hegde@amd.com>
Cc: iommu@lists.linux.dev, suravee.suthikulpanit@amd.com,
Klara Modin <klarasmodin@gmail.com>
Subject: Re: [PATCH] iommu/amd: Enable Guest Translation after reading IOMMU feature register
Date: Mon, 6 May 2024 10:25:56 +0200 [thread overview]
Message-ID: <ZjiUFP7JF9fU88u1@8bytes.org> (raw)
In-Reply-To: <20240506082039.7575-1-vasant.hegde@amd.com>
On Mon, May 06, 2024 at 08:20:39AM +0000, Vasant Hegde wrote:
> Commit 8e0179733172 ("iommu/amd: Enable Guest Translation before
> registering devices") moved IOMMU Guest Translation (GT) enablement to
> early init path. It does feature check based on Global EFR value (got from
> ACPI IVRS table). Later it adjusts EFR value based on IOMMU feature
> register (late_iommu_features_init()).
>
> It seems in some systems BIOS doesn't set gloabl EFR value properly.
> This is causing mismatch. Hence move IOMMU GT enablement after
> late_iommu_features_init() so that it does check based on IOMMU EFR
> value.
>
> Link: https://lore.kernel.org/linux-iommu/333e6eb6-361c-4afb-8107-2573324bf689@gmail.com/
> Fixes: 8e0179733172 ("iommu/amd: Enable Guest Translation before registering devices")
> Reported-by: Klara Modin <klarasmodin@gmail.com>
> Signed-off-by: Vasant Hegde <vasant.hegde@amd.com>
> Tested-by: Klara Modin <klarasmodin@gmail.com>
> ---
> drivers/iommu/amd/init.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Wow, that was quick. Applied now, thanks!
prev parent reply other threads:[~2024-05-06 8:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-06 8:20 [PATCH] iommu/amd: Enable Guest Translation after reading IOMMU feature register Vasant Hegde
2024-05-06 8:25 ` Joerg Roedel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZjiUFP7JF9fU88u1@8bytes.org \
--to=joro@8bytes.org \
--cc=iommu@lists.linux.dev \
--cc=klarasmodin@gmail.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=vasant.hegde@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).