From: Tyler Hicks <code@tyhicks.com>
To: Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
Jerry Snitselaar <jsnitsel@redhat.com>
Cc: linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev,
linux-kernel@vger.kernel.org, Dexuan Cui <decui@microsoft.com>,
Easwar Hariharan <eahariha@linux.microsoft.com>
Subject: Why is the ARM SMMU v1/v2 put into bypass mode on kexec?
Date: Thu, 14 Mar 2024 02:49:20 -0500 [thread overview]
Message-ID: <ZfKsAIt8RY/JcL/V@sequoia> (raw)
Given that drivers are only optionally asked to implement the .shutdown
hook, which is required to properly quiesce devices before a kexec, why
is it that we put the ARM SMMU v1/v2 into bypass mode in the arm-smmu
driver's own .shutdown hook?
arm_smmu_device_shutdown() -> set SMMU_sCR0.CLIENTPD bit to 1
Driver authors often forget to even implement a .shutdown hook, which
results in some hard-to-debug memory corruption issues in the kexec'ed
target kernel due to pending DMA operations happening on untranslated
addresses. Why not leave the SMMU in translate mode but clear the stream
mapping table (or maybe even call arm_smmu_device_reset()) in the SMMU's
.shutdown hook to prevent the memory corruption from happening in the
first place?
Fully acknowledging that the proper fix is to quiesce the devices, I
feel like resetting the SMMU and leaving it in translate mode across
kexec would be more consistent with the intent behind v5.2 commit
954a03be033c ("iommu/arm-smmu: Break insecure users by disabling bypass
by default"). The incoming transactions of devices, that weren't
properly quiesced during a kexec, would be blocked until their drivers
have a chance to reinitialize the devices in the new kernel.
I appreciate any help understanding why bypass mode is utilized here as
I'm sure there are nuances that I haven't considered. Thank you!
Tyler
next reply other threads:[~2024-03-14 7:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-14 7:49 Tyler Hicks [this message]
2024-03-14 19:06 ` Why is the ARM SMMU v1/v2 put into bypass mode on kexec? Tyler Hicks
2024-03-19 12:57 ` Robin Murphy
2024-03-19 15:47 ` Will Deacon
2024-03-19 17:50 ` Jason Gunthorpe
2024-03-22 15:55 ` Will Deacon
2024-03-22 19:52 ` Tyler Hicks
2024-03-19 18:17 ` Robin Murphy
2024-03-22 15:51 ` Will Deacon
2024-04-02 16:32 ` Robin Murphy
2024-03-19 19:14 ` Tyler Hicks
2024-03-22 16:06 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZfKsAIt8RY/JcL/V@sequoia \
--to=code@tyhicks.com \
--cc=decui@microsoft.com \
--cc=eahariha@linux.microsoft.com \
--cc=iommu@lists.linux.dev \
--cc=jgg@ziepe.ca \
--cc=jsnitsel@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).