From: "Tian, Kevin" <kevin.tian@intel.com>
To: Lu Baolu <baolu.lu@linux.intel.com>,
Jason Gunthorpe <jgg@ziepe.ca>, "Joerg Roedel" <joro@8bytes.org>,
Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Jean-Philippe Brucker <jean-philippe@linaro.org>,
Nicolin Chen <nicolinc@nvidia.com>,
"Liu, Yi L" <yi.l.liu@intel.com>,
"Jacob Pan" <jacob.jun.pan@linux.intel.com>,
Joel Granados <j.granados@samsung.com>
Cc: "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v5 2/9] iommu: Replace sva_iommu with iommu_attach_handle
Date: Wed, 15 May 2024 07:21:23 +0000 [thread overview]
Message-ID: <BN9PR11MB527615219EEF0EF3EACCF38D8CEC2@BN9PR11MB5276.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20240430145710.68112-3-baolu.lu@linux.intel.com>
> From: Lu Baolu <baolu.lu@linux.intel.com>
> Sent: Tuesday, April 30, 2024 10:57 PM
>
> #else
> -static inline struct iommu_sva *
> +static inline struct iommu_attach_handle *
> iommu_sva_bind_device(struct device *dev, struct mm_struct *mm)
> {
> - return NULL;
> + return ERR_PTR(-ENODEV);
> }
>
this should be a separate fix.
existing drivers (idxd and uacce) only check IS_ERR() on the return
value. A Null pointer may lead to an error reported at a later point.
next prev parent reply other threads:[~2024-05-15 7:21 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-30 14:57 [PATCH v5 0/9] IOMMUFD: Deliver IO page faults to user space Lu Baolu
2024-04-30 14:57 ` [PATCH v5 1/9] iommu: Introduce domain attachment handle Lu Baolu
2024-05-15 7:17 ` Tian, Kevin
2024-05-19 10:07 ` Baolu Lu
2024-04-30 14:57 ` [PATCH v5 2/9] iommu: Replace sva_iommu with iommu_attach_handle Lu Baolu
2024-05-07 23:58 ` Jason Gunthorpe
2024-05-15 7:21 ` Tian, Kevin [this message]
2024-05-19 10:14 ` Baolu Lu
2024-05-20 3:18 ` Tian, Kevin
2024-04-30 14:57 ` [PATCH v5 3/9] iommu: Add attachment handle to struct iopf_group Lu Baolu
2024-05-08 0:04 ` Jason Gunthorpe
2024-05-10 3:14 ` Baolu Lu
2024-05-10 13:38 ` Jason Gunthorpe
2024-05-10 14:30 ` Baolu Lu
2024-05-10 16:28 ` Jason Gunthorpe
2024-05-15 7:28 ` Tian, Kevin
2024-05-15 7:31 ` Tian, Kevin
2024-05-19 14:03 ` Baolu Lu
2024-05-20 3:20 ` Tian, Kevin
2024-04-30 14:57 ` [PATCH v5 4/9] iommufd: Add fault and response message definitions Lu Baolu
2024-05-15 7:43 ` Tian, Kevin
2024-05-19 14:37 ` Baolu Lu
2024-05-20 3:24 ` Tian, Kevin
2024-05-20 3:33 ` Baolu Lu
2024-05-20 4:59 ` Tian, Kevin
2024-05-24 14:15 ` Jason Gunthorpe
2024-05-27 1:27 ` Tian, Kevin
2024-04-30 14:57 ` [PATCH v5 5/9] iommufd: Add iommufd fault object Lu Baolu
2024-05-08 0:11 ` Jason Gunthorpe
2024-05-08 10:05 ` Baolu Lu
2024-05-15 7:57 ` Tian, Kevin
2024-05-20 0:41 ` Baolu Lu
2024-05-20 3:26 ` Tian, Kevin
2024-05-20 3:28 ` Baolu Lu
2024-05-08 0:22 ` Jason Gunthorpe
2024-05-10 9:13 ` Baolu Lu
2024-05-15 8:37 ` Tian, Kevin
2024-05-20 1:15 ` Baolu Lu
2024-05-20 1:24 ` Baolu Lu
2024-05-24 14:16 ` Jason Gunthorpe
2024-05-20 1:33 ` Baolu Lu
2024-05-20 3:33 ` Tian, Kevin
2024-05-20 1:38 ` Baolu Lu
2024-04-30 14:57 ` [PATCH v5 6/9] iommufd: Fault-capable hwpt attach/detach/replace Lu Baolu
2024-05-08 0:18 ` Jason Gunthorpe
2024-05-10 3:20 ` Baolu Lu
2024-05-10 13:39 ` Jason Gunthorpe
2024-05-15 8:43 ` Tian, Kevin
2024-05-20 2:10 ` Baolu Lu
2024-05-20 3:35 ` Tian, Kevin
2024-05-20 3:55 ` Baolu Lu
2024-04-30 14:57 ` [PATCH v5 7/9] iommufd: Associate fault object with iommufd_hw_pgtable Lu Baolu
2024-05-08 0:25 ` Jason Gunthorpe
2024-05-10 3:23 ` Baolu Lu
2024-05-15 8:50 ` Tian, Kevin
2024-05-20 2:18 ` Baolu Lu
2024-05-20 3:39 ` Tian, Kevin
2024-05-20 4:00 ` Baolu Lu
2024-05-24 14:24 ` Jason Gunthorpe
2024-05-27 1:33 ` Tian, Kevin
2024-05-27 3:16 ` Baolu Lu
2024-04-30 14:57 ` [PATCH v5 8/9] iommufd/selftest: Add IOPF support for mock device Lu Baolu
2024-04-30 14:57 ` [PATCH v5 9/9] iommufd/selftest: Add coverage for IOPF test Lu Baolu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN9PR11MB527615219EEF0EF3EACCF38D8CEC2@BN9PR11MB5276.namprd11.prod.outlook.com \
--to=kevin.tian@intel.com \
--cc=baolu.lu@linux.intel.com \
--cc=iommu@lists.linux.dev \
--cc=j.granados@samsung.com \
--cc=jacob.jun.pan@linux.intel.com \
--cc=jean-philippe@linaro.org \
--cc=jgg@ziepe.ca \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolinc@nvidia.com \
--cc=robin.murphy@arm.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=will@kernel.org \
--cc=yi.l.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).