From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Trilok Soni <quic_tsoni@quicinc.com>,
Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Joerg Roedel <joro@8bytes.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Clark <robdclark@gmail.com>,
Abhinav Kumar <quic_abhinavk@quicinc.com>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Sean Paul <sean@poorly.run>, David Airlie <airlied@gmail.com>,
Daniel Vetter <daniel@ffwll.ch>
Cc: Marijn Suijten <marijn.suijten@somainline.org>,
linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Konrad Dybcio <konradybcio@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org
Subject: Re: [PATCH v2 2/7] clk: qcom: clk-alpha-pll: Add HUAYRA_2290 support
Date: Tue, 12 Mar 2024 17:12:19 +0100 [thread overview]
Message-ID: <83734790-85c5-446f-b353-f3765cb10d41@linaro.org> (raw)
In-Reply-To: <605d9e50-d61b-b0ce-1664-00554ba70b41@quicinc.com>
On 2/23/24 23:48, Trilok Soni wrote:
> On 2/23/2024 1:21 PM, Konrad Dybcio wrote:
>> + /* Wait 50us for PLL_LOCK_DET bit to go high */
>> + usleep_range(50, 55);
>> +
>> + /* Enable PLL output */
>> + regmap_update_bits(regmap, PLL_MODE(pll), PLL_OUTCTRL, PLL_OUTCTRL);
>> +}
>> +EXPORT_SYMBOL(clk_huayra_2290_pll_configure);
>
> Please use EXPORT_SYMBOL_GPL.
Sure, I glanced over this!
I've also noticed that it's a very common oversight.. would you be
interested in extending scripts/checkpatch.pl to suggest the _GPL
variant?
Konrad
next prev parent reply other threads:[~2024-03-12 16:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-23 21:21 [PATCH v2 0/7] A702 support Konrad Dybcio
2024-02-23 21:21 ` [PATCH v2 1/7] dt-bindings: clock: Add Qcom QCM2290 GPUCC Konrad Dybcio
2024-02-24 10:20 ` Krzysztof Kozlowski
2024-02-23 21:21 ` [PATCH v2 2/7] clk: qcom: clk-alpha-pll: Add HUAYRA_2290 support Konrad Dybcio
2024-02-23 21:24 ` Dmitry Baryshkov
2024-02-23 22:48 ` Trilok Soni
2024-03-12 16:12 ` Konrad Dybcio [this message]
2024-02-23 21:21 ` [PATCH v2 3/7] clk: qcom: Add QCM2290 GPU clock controller driver Konrad Dybcio
2024-02-23 21:21 ` [PATCH v2 4/7] drm/msm/adreno: Add missing defines for A702 Konrad Dybcio
2024-02-23 21:24 ` Dmitry Baryshkov
2024-02-23 21:21 ` [PATCH v2 5/7] drm/msm/adreno: Add A702 support Konrad Dybcio
2024-05-23 12:14 ` Connor Abbott
2024-02-23 21:21 ` [PATCH v2 6/7] arm64: dts: qcom: qcm2290: Add GPU nodes Konrad Dybcio
2024-02-23 21:21 ` [PATCH v2 7/7] arm64: dts: qcom: qrb2210-rb1: Enable the GPU Konrad Dybcio
2024-02-27 10:10 ` [PATCH v2 0/7] A702 support Will Deacon
2024-02-27 10:12 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83734790-85c5-446f-b353-f3765cb10d41@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=airlied@gmail.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=konradybcio@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=mturquette@baylibre.com \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_tsoni@quicinc.com \
--cc=robdclark@gmail.com \
--cc=robh@kernel.org \
--cc=robin.murphy@arm.com \
--cc=sboyd@kernel.org \
--cc=sean@poorly.run \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).