From: Robin Murphy <robin.murphy@arm.com>
To: Chen Ni <nichen@iscas.ac.cn>,
joro@8bytes.org, will@kernel.org, heiko@sntech.de,
jeffy.chen@rock-chips.com
Cc: iommu@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iommu/rockchip: Add missing check for of_find_device_by_node
Date: Thu, 25 Apr 2024 11:35:53 +0100 [thread overview]
Message-ID: <473f2b61-9015-481a-b231-b642f6c7be41@arm.com> (raw)
In-Reply-To: <20240425091813.965003-1-nichen@iscas.ac.cn>
On 25/04/2024 10:18 am, Chen Ni wrote:
> Add check for the return value of of_find_device_by_node() and return
> the error if it fails in order to avoid NULL pointer dereference.
How would it return NULL?
Or to put it another way, if a device has somehow vanished without
unbinding its driver or unregistering the iommu_ops through which this
is called, then the kernel state is clearly so broken that crashing is
probably the safest thing to do. Furthermore if we couldn't assume we
have the right device here then we also couldn't assume that its drvdata
points to the right thing either, so we'd be rather stuck.
Thanks,
Robin.
> Fixes: 5fd577c3eac3 ("iommu/rockchip: Use OF_IOMMU to attach devices automatically")
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> ---
> drivers/iommu/rockchip-iommu.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/iommu/rockchip-iommu.c b/drivers/iommu/rockchip-iommu.c
> index 4b369419b32c..1225c1df6ef6 100644
> --- a/drivers/iommu/rockchip-iommu.c
> +++ b/drivers/iommu/rockchip-iommu.c
> @@ -1152,6 +1152,8 @@ static int rk_iommu_of_xlate(struct device *dev,
> return -ENOMEM;
>
> iommu_dev = of_find_device_by_node(args->np);
> + if (!iommu_dev)
> + return -ENODEV;
>
> data->iommu = platform_get_drvdata(iommu_dev);
> data->iommu->domain = &rk_identity_domain;
prev parent reply other threads:[~2024-04-25 10:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-25 9:18 [PATCH] iommu/rockchip: Add missing check for of_find_device_by_node Chen Ni
2024-04-25 10:35 ` Robin Murphy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=473f2b61-9015-481a-b231-b642f6c7be41@arm.com \
--to=robin.murphy@arm.com \
--cc=heiko@sntech.de \
--cc=iommu@lists.linux.dev \
--cc=jeffy.chen@rock-chips.com \
--cc=joro@8bytes.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=nichen@iscas.ac.cn \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).