IOMMU Archive mirror
 help / color / mirror / Atom feed
From: Vasant Hegde <vashegde@amd.com>
To: Tom Lendacky <thomas.lendacky@amd.com>,
	Vasant Hegde <vasant.hegde@amd.com>,
	iommu@lists.linux.dev, joro@8bytes.org
Cc: suravee.suthikulpanit@amd.com,
	Ashish Kalra <ashish.kalra@amd.com>,
	Michael Roth <michael.roth@amd.com>
Subject: Re: [PATCH rc] iommu/amd: Do not enable SNP when V2 page table is enabled
Date: Mon, 8 Apr 2024 10:40:46 +0530	[thread overview]
Message-ID: <2b2da6fe-9edb-4f7a-b917-6f9cfda6ec56@amd.com> (raw)
In-Reply-To: <5187cf7a-7263-7635-90ad-b298e14b8ce1@amd.com>

Tom,


On 4/4/2024 7:04 PM, Tom Lendacky wrote:
> On 4/4/24 05:37, Vasant Hegde wrote:
>> DTE[Mode]=0 is not supported when SNP is enabled in the host. That means
>> to support SNP, IOMMU must be configued with V1 page table (See IOMMU
>> spec [1] for the details). If user passes kernel command line to 
>> configure
>> IOMMU domains with v2 page table (amd_iommu=pgtbl_v2) then disable SNP.
>>
>> [1] 
>> https://www.amd.com/content/dam/amd/en/documents/processor-tech-docs/specifications/48882_IOMMU.pdf
>>
>> Cc: Ashish Kalra <ashish.kalra@amd.com>
>> Cc: Michael Roth <michael.roth@amd.com>
>> Cc: Tom Lendacky <thomas.lendacky@amd.com>
>> Signed-off-by: Vasant Hegde <vasant.hegde@amd.com>
> 
> Just a heads up, but this will likely end up with a conflict after tip
> just merged changes around this area.
> 
> https://lore.kernel.org/lkml/171222187434.10875.5343618940901502172.tip-bot2@tip-bot2/


Ah right. I will rebase/resend this patch.

-Vasant


      reply	other threads:[~2024-04-08  5:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-04 10:37 [PATCH rc] iommu/amd: Do not enable SNP when V2 page table is enabled Vasant Hegde
2024-04-04 13:34 ` Tom Lendacky
2024-04-08  5:10   ` Vasant Hegde [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2b2da6fe-9edb-4f7a-b917-6f9cfda6ec56@amd.com \
    --to=vashegde@amd.com \
    --cc=ashish.kalra@amd.com \
    --cc=iommu@lists.linux.dev \
    --cc=joro@8bytes.org \
    --cc=michael.roth@amd.com \
    --cc=suravee.suthikulpanit@amd.com \
    --cc=thomas.lendacky@amd.com \
    --cc=vasant.hegde@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).