From: Jason Gunthorpe <jgg@ziepe.ca>
To: Zong Li <zong.li@sifive.com>
Cc: joro@8bytes.org, will@kernel.org, robin.murphy@arm.com,
tjeznach@rivosinc.com, paul.walmsley@sifive.com,
palmer@dabbelt.com, aou@eecs.berkeley.edu, kevin.tian@intel.com,
linux-kernel@vger.kernel.org, iommu@lists.linux.dev,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH RFC RESEND 6/6] iommu/riscv: support nested iommu for flushing cache
Date: Tue, 7 May 2024 13:27:02 -0300 [thread overview]
Message-ID: <20240507162702.GC4718@ziepe.ca> (raw)
In-Reply-To: <CANXhq0rnWUT4ia-cUoTbSyEQUeCcmC9bC7HHru6Se-1K-PZRDQ@mail.gmail.com>
On Tue, May 07, 2024 at 11:35:16PM +0800, Zong Li wrote:
> > > + default:
> > > + pr_warn("The user command: 0x%x is not supported\n", opcode);
> > > + return -EOPNOTSUPP;
> >
> > No userspace triggerable warnings.
>
> I don't complete understand about this. Could I know whether we should
> suppress the message and return the error directly, or if we should
> convert the warning to an error (i.e. pr_err)?
A userspace system call should never print to dmesg. Return an error
code. Put a pr_debug if you really care.
Jason
prev parent reply other threads:[~2024-05-07 16:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-07 14:25 [PATCH RFC RESEND 0/6] RISC-V IOMMU HPM and nested IOMMU support Zong Li
2024-05-07 14:25 ` [PATCH RFC RESEND 1/6] iommu/riscv: Add RISC-V IOMMU PMU support Zong Li
2024-05-07 14:25 ` [PATCH RFC RESEND 2/6] iommu/riscv: Support HPM and interrupt handling Zong Li
2024-05-07 14:25 ` [PATCH RFC RESEND 3/6] iommu/riscv: support GSCID Zong Li
2024-05-07 15:15 ` Jason Gunthorpe
2024-05-07 15:52 ` Zong Li
2024-05-07 16:25 ` Jason Gunthorpe
2024-05-07 14:25 ` [PATCH RFC RESEND 4/6] iommu/riscv: support nested iommu for getting iommu hardware information Zong Li
2024-05-07 14:54 ` Jason Gunthorpe
2024-05-07 15:19 ` Zong Li
2024-05-07 14:25 ` [PATCH RFC RESEND 5/6] iommu/riscv: support nested iommu for creating domains owned by userspace Zong Li
2024-05-07 15:07 ` Jason Gunthorpe
2024-05-07 14:26 ` [PATCH RFC RESEND 6/6] iommu/riscv: support nested iommu for flushing cache Zong Li
2024-05-07 15:08 ` Jason Gunthorpe
2024-05-07 15:35 ` Zong Li
2024-05-07 16:27 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240507162702.GC4718@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=aou@eecs.berkeley.edu \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robin.murphy@arm.com \
--cc=tjeznach@rivosinc.com \
--cc=will@kernel.org \
--cc=zong.li@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).