From: Will Deacon <will@kernel.org>
To: robin.murphy@arm.com, linux-arm-kernel@lists.infradead.org,
iommu@lists.linux.dev, Mostafa Saleh <smostafa@google.com>
Cc: catalin.marinas@arm.com, kernel-team@android.com,
Will Deacon <will@kernel.org>,
linux-kernel@vger.kernel.org, joro@8bytes.org,
nicolinc@nvidia.com, mshavit@google.com,
Jason Gunthorpe <jgg@ziepe.ca>
Subject: Re: [PATCH] iommu/arm-smmu-v3: Fix access for STE.SHCFG
Date: Tue, 26 Mar 2024 17:23:18 +0000 [thread overview]
Message-ID: <171145006028.35099.17017166136066755497.b4-ty@kernel.org> (raw)
In-Reply-To: <20240323134658.464743-1-smostafa@google.com>
On Sat, 23 Mar 2024 13:46:58 +0000, Mostafa Saleh wrote:
> STE attributes(NSCFG, PRIVCFG, INSTCFG) use value 0 for "Use Icomming",
> for some reason SHCFG doesn't follow that, and it is defined as "0b01".
>
> Currently the driver sets SHCFG to Use Incoming for stage-2 and bypass
> domains.
>
> However according to the User Manual (ARM IHI 0070 F.b):
> When SMMU_IDR1.ATTR_TYPES_OVR == 0, this field is RES0 and the
> incoming Shareability attribute is used.
>
> [...]
Applied to will (for-joerg/arm-smmu/fixes), thanks!
[1/1] iommu/arm-smmu-v3: Fix access for STE.SHCFG
https://git.kernel.org/will/c/ec9098d6bffe
Cheers,
--
Will
https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev
prev parent reply other threads:[~2024-03-26 17:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-23 13:46 [PATCH] iommu/arm-smmu-v3: Fix access for STE.SHCFG Mostafa Saleh
2024-03-25 13:18 ` Jason Gunthorpe
2024-03-26 17:23 ` Will Deacon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171145006028.35099.17017166136066755497.b4-ty@kernel.org \
--to=will@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=iommu@lists.linux.dev \
--cc=jgg@ziepe.ca \
--cc=joro@8bytes.org \
--cc=kernel-team@android.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mshavit@google.com \
--cc=nicolinc@nvidia.com \
--cc=robin.murphy@arm.com \
--cc=smostafa@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).