From: Mimi Zohar <zohar@linux.ibm.com>
To: Enrico Bravi <enrico.bravi@polito.it>,
Roberto Sassu <roberto.sassu@huaweicloud.com>,
linux-integrity@vger.kernel.org, dmitry.kasatkin@gmail.com
Cc: roberto.sassu@huawei.com, Silvia Sisinni <silvia.sisinni@polito.it>
Subject: Re: [PATCH v5] ima: add crypto agility support for template-hash algorithm
Date: Mon, 08 Apr 2024 12:01:30 -0400 [thread overview]
Message-ID: <b59689cb482eee80586bc20fce4a832bad5246f2.camel@linux.ibm.com> (raw)
In-Reply-To: <eb69441f-08aa-40b2-a667-437367a83c2a@polito.it>
On Mon, 2024-04-08 at 17:43 +0200, Enrico Bravi wrote:
> On 08/04/24 13:35, Roberto Sassu wrote:
> > On Mon, 2024-04-08 at 13:17 +0200, Enrico Bravi wrote:
> > > The template hash showed by the ascii_runtime_measurements and
> > > binary_runtime_measurements is the one calculated using sha1 and there is
> > > no possibility to change this value, despite the fact that the template
> > > hash is calculated using the hash algorithms corresponding to all the PCR
> > > banks configured in the TPM.
> > >
> > > Add the support to retrieve the ima log with the template data hash
> > > calculated with a specific hash algorithm.
> > > Add a new file in the securityfs ima directory for each hash algo
> > > configured in a PCR bank of the TPM. Each new file has the name with
> > > the following structure:
> > >
> > > {binary, ascii}_runtime_measurements_<hash_algo_name>
> > >
> > > Legacy files are kept, to avoid breaking existing applications, but as
> > > symbolic links which point to {binary, ascii}_runtime_measurements_sha1
> > > files. These two files are created even if a TPM chip is not detected or
> > > the sha1 bank is not configured in the TPM.
> > >
> > > As example, in the case a TPM chip is present and sha256 is the only
> > > configured PCR bank, the listing of the securityfs ima directory is the
> > > following:
> > >
> > > lr--r--r-- [...] ascii_runtime_measurements ->
> > > ascii_runtime_measurements_sha1
> > > -r--r----- [...] ascii_runtime_measurements_sha1
> > > -r--r----- [...] ascii_runtime_measurements_sha256
> > > lr--r--r-- [...] binary_runtime_measurements ->
> > > binary_runtime_measurements_sha1
> > > -r--r----- [...] binary_runtime_measurements_sha1
> > > -r--r----- [...] binary_runtime_measurements_sha256
> > > --w------- [...] policy
> > > -r--r----- [...] runtime_measurements_count
> > > -r--r----- [...] violations
> > >
> > > Signed-off-by: Enrico Bravi <enrico.bravi@polito.it>
> > > Signed-off-by: Silvia Sisinni <silvia.sisinni@polito.it>
> >
> > Reviewed-by: Roberto Sassu <roberto.sassu@huawei.com>
>
> Thank you Roberto for the tag!
>
> I noticed an error in the number of changed lines which produces a format
> error
> when applying the patch. I will send shortly a new version which fixes it.
>
> I'm so sorry about that.
>
Thanks, Enrico. Please base it on the next-integrity branch.
Mimi
prev parent reply other threads:[~2024-04-08 16:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-08 11:17 [PATCH v5] ima: add crypto agility support for template-hash algorithm Enrico Bravi
2024-04-08 11:35 ` Roberto Sassu
2024-04-08 15:43 ` Enrico Bravi
2024-04-08 16:01 ` Mimi Zohar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b59689cb482eee80586bc20fce4a832bad5246f2.camel@linux.ibm.com \
--to=zohar@linux.ibm.com \
--cc=dmitry.kasatkin@gmail.com \
--cc=enrico.bravi@polito.it \
--cc=linux-integrity@vger.kernel.org \
--cc=roberto.sassu@huawei.com \
--cc=roberto.sassu@huaweicloud.com \
--cc=silvia.sisinni@polito.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).