From: Ninad Palsule <ninad@linux.ibm.com>
To: Mark Brown <broonie@kernel.org>
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, joel@jms.id.au, andrew@codeconstruct.com.au,
peterhuewe@gmx.de, jarkko@kernel.org, jgg@ziepe.ca,
keescook@chromium.org, tony.luck@intel.com, gpiccoli@igalia.com,
johannes.holland@infineon.com, linux@roeck-us.net,
andre.werner@systec-electronic.com,
Andrew Geissler <geissonator@yahoo.com>,
patrick.rudolph@9elements.com, vincent@vtremblay.dev,
peteryin.openbmc@gmail.com, lakshmiy@us.ibm.com,
bhelgaas@google.com, naresh.solanki@9elements.com,
alexander.stein@ew.tq-group.com, festevam@denx.de,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
linux-integrity@vger.kernel.org, linux-hardening@vger.kernel.org,
geert+renesas@glider.be, luca.ceresoli@bootlin.com
Subject: Re: [PATCH v2 3/3] ARM: dts: aspeed: System1: IBM system1 BMC board
Date: Tue, 9 Jan 2024 17:36:05 -0600 [thread overview]
Message-ID: <aeabec28-a3a8-4ce1-b95b-a548cd27d626@linux.ibm.com> (raw)
In-Reply-To: <b09d6e54-66e9-482f-8f45-38381fa6b62e@sirena.org.uk>
Hello Mark,
On 1/8/24 15:34, Mark Brown wrote:
> On Mon, Jan 08, 2024 at 02:41:14PM -0600, Ninad Palsule wrote:
>
>> + regulator@60 {
>> + compatible = "maxim,max8952";
>> + reg = <0x60>;
>> +
>> + max8952,default-mode = <0>;
>> + max8952,dvs-mode-microvolt = <1250000>, <1200000>,
>> + <1050000>, <950000>;
>> + max8952,sync-freq = <0>;
>> + max8952,ramp-speed = <0>;
>> +
>> + regulator-name = "VR_1.0V";
>> + regulator-min-microvolt = <770000>;
>> + regulator-max-microvolt = <1400000>;
> A regulator labelled VR_1.0V can vary between 0.77V and 1.4V and has
> exactly the same configuration as another regulator labelled VR_1.2V?
> That seems... odd?
That was a typo. I fixed it.
Thanks for the review.
Regards,
Ninad
prev parent reply other threads:[~2024-01-09 23:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-08 20:41 [PATCH v2 0/3] Add device tree for IBM system1 BMC Ninad Palsule
2024-01-08 20:41 ` [PATCH v2 1/3] dt-bindings: arm: aspeed: add IBM system1-bmc Ninad Palsule
2024-01-09 9:25 ` Krzysztof Kozlowski
2024-01-08 20:41 ` [PATCH v2 2/3] dt-bindings: Add DPS310 as trivial device Ninad Palsule
2024-01-09 9:25 ` Krzysztof Kozlowski
2024-01-08 20:41 ` [PATCH v2 3/3] ARM: dts: aspeed: System1: IBM system1 BMC board Ninad Palsule
2024-01-08 21:34 ` Mark Brown
2024-01-09 23:36 ` Ninad Palsule [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aeabec28-a3a8-4ce1-b95b-a548cd27d626@linux.ibm.com \
--to=ninad@linux.ibm.com \
--cc=alexander.stein@ew.tq-group.com \
--cc=andre.werner@systec-electronic.com \
--cc=andrew@codeconstruct.com.au \
--cc=bhelgaas@google.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@denx.de \
--cc=geert+renesas@glider.be \
--cc=geissonator@yahoo.com \
--cc=gpiccoli@igalia.com \
--cc=jarkko@kernel.org \
--cc=jgg@ziepe.ca \
--cc=joel@jms.id.au \
--cc=johannes.holland@infineon.com \
--cc=keescook@chromium.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lakshmiy@us.ibm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=luca.ceresoli@bootlin.com \
--cc=naresh.solanki@9elements.com \
--cc=patrick.rudolph@9elements.com \
--cc=peterhuewe@gmx.de \
--cc=peteryin.openbmc@gmail.com \
--cc=robh+dt@kernel.org \
--cc=tony.luck@intel.com \
--cc=vincent@vtremblay.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).