From: "Jarkko Sakkinen" <jarkko@kernel.org>
To: "Niklas Schnelle" <schnelle@linux.ibm.com>,
"Peter Huewe" <peterhuewe@gmx.de>
Cc: <linux-integrity@vger.kernel.org>,
"Heiko Carstens" <hca@linux.ibm.com>,
<linux-kernel@vger.kernel.org>, "Arnd Bergmann" <arnd@kernel.org>
Subject: Re: [PATCH] char: tpm: Keep TPM_INF_IO_PORT define for HAS_IOPORT=n
Date: Wed, 24 Apr 2024 00:33:27 +0300 [thread overview]
Message-ID: <D0RTOKUKOP3M.15LBA63K3KVWP@kernel.org> (raw)
In-Reply-To: <20240422123711.1739063-1-schnelle@linux.ibm.com>
On Mon Apr 22, 2024 at 3:37 PM EEST, Niklas Schnelle wrote:
> The recent change to handle HAS_IOPORT removed the TPM_INF_IO_PORT
> define for the HAS_IOPORT=n case despite the define being used in
> sections of code not covered by the same ifdef check. This was missed
> because at the moment TCG_INFINEON indirectly depends on HAS_IOPORT via
> PNP which depends on ACPI || ISA. As TCG_INFINEON does in principle
> support MMIO only use add it for COMPILE_TEST to cover the HAS_IOPORT=n
> case.
>
> Link: https://lore.kernel.org/lkml/9d9fa267-067e-421b-9a39-aa178b913298@app.fastmail.com/
> Fixes: dab56f80e7f9 ("char: tpm: handle HAS_IOPORT dependencies")
> Signed-off-by: Niklas Schnelle <schnelle@linux.ibm.com>
Thanks!
Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
I applied it to my master but for some reason it is not yet reflected
to web ui:
https://git.kernel.org/pub/scm/linux/kernel/git/jarkko/linux-tpmdd.git/log/
But it is still applied and perhaps also visible when you seee this!
BR, Jarkko
prev parent reply other threads:[~2024-04-23 21:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-22 12:37 [PATCH] char: tpm: Keep TPM_INF_IO_PORT define for HAS_IOPORT=n Niklas Schnelle
2024-04-23 21:33 ` Jarkko Sakkinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D0RTOKUKOP3M.15LBA63K3KVWP@kernel.org \
--to=jarkko@kernel.org \
--cc=arnd@kernel.org \
--cc=hca@linux.ibm.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=schnelle@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).