From: "Jarkko Sakkinen" <jarkko@kernel.org>
To: "Luck, Tony" <tony.luck@intel.com>,
"Paul Menzel" <pmenzel@molgen.mpg.de>,
"Peter Huewe" <peterhuewe@gmx.de>
Cc: "Jason Gunthorpe" <jgg@ziepe.ca>,
"linux-integrity@vger.kernel.org"
<linux-integrity@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"patches@lists.linux.dev" <patches@lists.linux.dev>
Subject: Re: [PATCH v3 42/74] x86/cpu/vfm: Update tpm files
Date: Thu, 18 Apr 2024 01:48:24 +0300 [thread overview]
Message-ID: <D0MRIPCIFS8O.1G6VY45KFAMBE@kernel.org> (raw)
In-Reply-To: <SJ1PR11MB608327EBA734DB11B2DAFC84FC0F2@SJ1PR11MB6083.namprd11.prod.outlook.com>
On Wed Apr 17, 2024 at 7:43 PM EEST, Luck, Tony wrote:
> > Thank you for your patch. It’d be great if you changed the commit
> > message summary/title to be more specific. Currently, the short log,
> > `git log --oneline`, is not very meaningful. Maybe:
> >
> > tpm: Use new VFM macro INTEL_ATOM_AIRMONT
> >
> > or
> >
> > x86/cpu/vfm: Use macro INTEL_ATOM_AIRMONT in tpm
>
> Paul,
>
> With 74 patches in this series there was a lot of automation. I'll
> see about updating "Subject:" lines to match subsystem conventions
> before these are applied.
>
> Apart from that, are you OK with the contents of this patch?
>
> -Tony
For the possible subject-line change: please *do not* remove my reviewed-by :-)
BR, Jarkko
prev parent reply other threads:[~2024-04-17 22:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240416211941.9369-1-tony.luck@intel.com>
2024-04-16 21:22 ` [PATCH v3 42/74] x86/cpu/vfm: Update tpm files Tony Luck
2024-04-17 15:41 ` Jarkko Sakkinen
2024-04-17 16:38 ` Luck, Tony
2024-04-17 22:10 ` Jarkko Sakkinen
2024-04-17 16:07 ` Paul Menzel
2024-04-17 16:43 ` Luck, Tony
2024-04-17 22:48 ` Jarkko Sakkinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D0MRIPCIFS8O.1G6VY45KFAMBE@kernel.org \
--to=jarkko@kernel.org \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@lists.linux.dev \
--cc=peterhuewe@gmx.de \
--cc=pmenzel@molgen.mpg.de \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).