From: "Jarkko Sakkinen" <jarkko@kernel.org>
To: "Jarkko Sakkinen" <jarkko@kernel.org>, "Adam Alves" <adamoa@gmail.com>
Cc: "Peter Huewe" <peterhuewe@gmx.de>,
"Jason Gunthorpe" <jgg@ziepe.ca>,
<linux-integrity@vger.kernel.org>
Subject: Re: [PATCH v2] tpm: Fix suspend/shutdown on some boards by preserving chip Locality
Date: Tue, 19 Mar 2024 23:41:09 +0200 [thread overview]
Message-ID: <CZY1XEOMDK7V.V71NXQCTEI5N@kernel.org> (raw)
In-Reply-To: <CZY1V4JMNR4U.3GTTNERY5MA6K@kernel.org>
On Tue Mar 19, 2024 at 11:38 PM EET, Jarkko Sakkinen wrote:
> On Tue Mar 19, 2024 at 9:57 PM EET, Jarkko Sakkinen wrote:
> > On Wed Mar 13, 2024 at 7:02 PM EET, Adam Alves wrote:
> > > Hi Jarkko,
> > >
> > > Thank you very much for kindly reviewing this proposal.
> > >
> > > After one week without any issues with my PC hanging, it happened
> > > again. It seems that the fix I am proposing is not final (it only
> > > reduced the frequency since it always happened when I shutdown after
> > > couple hours of power up time and now it only happened after two weeks
> > > with a similar usage rate).
> > >
> > > I will share with you the data you requested below.
> >
> > Thanks I'll definitely check these in detail.
> >
> > Any possible bug fix (if we decide to fix anything) is tpm_crb.c
> > including possible kernel command-line parameters or whatever. The
> > current proposal affects all the possible pieces of TPM hardware so
> > in all cases it is unacceptable.
> >
> > Do you have dmesg/journactl transcript? Did you try to update the
> > firmware?
>
> OK so I do have ASUS motherboard and my TPM2 ACPI table is almost the
> same match but:
>
> BIOS Information
> Vendor: American Megatrends Inc.
> Version: 2212
> Release Date: 12/13/2022
> Address: 0xF0000
> Runtime Size: 64 kB
> ROM Size: 24 MB
>
> Where as in you dmidecode.txt:
>
> Handle 0x0000, DMI type 0, 26 bytes
> BIOS Information
> Vendor: American Megatrends Inc.
> Version: 1601
> Release Date: 02/11/2022
> Address: 0xF0000
> Runtime Size: 64 kB
> ROM Size: 16 MB
>
> So at least the BIOS version is older. Can you update BIOS and see if
> that could possibly fix the issue?
>
> Make sure that it contains update for both BIOS and Management Engine.
AND if you end up still proposing any fix please make sure that it only
changes tpm_crb.c so that there is something to analyze. Sprinkled
arbitrary changes are not something we can really not say much.
If you don't know exactly what you are fixing and why please try to keep
the fix local to the issue. But yeah, BIOS update is really the first
trial here.
BR, Jarkko
prev parent reply other threads:[~2024-03-19 21:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-07 0:03 [PATCH 0/1] Fix TPM chip hanging system before suspend/shutdown Adam Alves
2024-03-07 0:03 ` [PATCH 1/1] " Adam Alves
2024-03-07 19:54 ` Jarkko Sakkinen
2024-03-07 22:17 ` Adam Alves
2024-03-07 22:49 ` [PATCH v2] tpm: Fix suspend/shutdown on some boards by preserving chip Locality Adam Alves
2024-03-08 9:33 ` Paul Menzel
2024-03-08 14:22 ` Adam Alves
2024-03-08 14:53 ` [PATCH v3] " Adam Alves
2024-03-11 20:04 ` [PATCH v2] " Jarkko Sakkinen
2024-03-13 17:02 ` Adam Alves
2024-03-14 16:31 ` Adam Alves
2024-03-14 16:32 ` Adam Alves
2024-03-19 20:07 ` Jarkko Sakkinen
2024-03-19 19:57 ` Jarkko Sakkinen
2024-03-19 21:38 ` Jarkko Sakkinen
2024-03-19 21:41 ` Jarkko Sakkinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CZY1XEOMDK7V.V71NXQCTEI5N@kernel.org \
--to=jarkko@kernel.org \
--cc=adamoa@gmail.com \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=peterhuewe@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).