From: "Jarkko Sakkinen" <jarkko@kernel.org>
To: "Jarkko Sakkinen" <jarkko@kernel.org>,
"Lukas Wunner" <lukas@wunner.de>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Peter Huewe" <peterhuewe@gmx.de>,
"Jason Gunthorpe" <jgg@ziepe.ca>,
"Tim Harvey" <tharvey@gateworks.com>
Cc: <devicetree@vger.kernel.org>, <linux-integrity@vger.kernel.org>
Subject: Re: [PATCH] dt-bindings: tpm: Add compatible string atmel,attpm20p
Date: Thu, 04 Jan 2024 21:11:16 +0200 [thread overview]
Message-ID: <CY65RSEA4VMD.MXHPX898TSW4@suppilovahvero> (raw)
In-Reply-To: <CY658TZN29WJ.2DMIWN3W68P2P@suppilovahvero>
On Thu Jan 4, 2024 at 8:46 PM EET, Jarkko Sakkinen wrote:
> On Thu Jan 4, 2024 at 6:50 PM EET, Jarkko Sakkinen wrote:
> > On Tue Jan 3, 2023 at 5:51 PM EET, Lukas Wunner wrote:
> > > Commit 4f2a348aa365 ("arm64: dts: imx8mm-venice-gw73xx: add TPM device")
> > > added a devicetree node for the Trusted Platform Module on certain
> > > Gateworks boards.
> > >
> > > The commit only used the generic "tcg,tpm_tis-spi" compatible string,
> > > but public documentation shows that the chip is an ATTPM20P from Atmel
> > > (nowadays Microchip):
> > > https://trac.gateworks.com/wiki/tpm
> > >
> > > Add the chip to the supported compatible strings of the TPM TIS SPI
> > > schema.
> > >
> > > For reference, a datasheet is available at:
> > > https://ww1.microchip.com/downloads/en/DeviceDoc/ATTPM20P-Trusted-Platform-Module-TPM-2.0-SPI-Interface-Summary-Data-Sheet-DS40002082A.pdf
> > >
> > > Signed-off-by: Lukas Wunner <lukas@wunner.de>
> > > Cc: Tim Harvey <tharvey@gateworks.com>
> > > ---
> > > This patch depends on the following series to consolidate TCG TIS bindings:
> > > https://lore.kernel.org/all/cover.1702806810.git.lukas@wunner.de/
> > >
> > > Documentation/devicetree/bindings/tpm/tcg,tpm_tis-spi.yaml | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/tpm/tcg,tpm_tis-spi.yaml b/Documentation/devicetree/bindings/tpm/tcg,tpm_tis-spi.yaml
> > > index c3413b4..6cb2de7 100644
> > > --- a/Documentation/devicetree/bindings/tpm/tcg,tpm_tis-spi.yaml
> > > +++ b/Documentation/devicetree/bindings/tpm/tcg,tpm_tis-spi.yaml
> > > @@ -20,6 +20,7 @@ properties:
> > > compatible:
> > > items:
> > > - enum:
> > > + - atmel,attpm20p
> > > - infineon,slb9670
> > > - st,st33htpm-spi
> > > - st,st33zp24-spi
> >
> > Acked-by: Jarkko Sakkinen <jarkko@kernel.org>
>
> meant:
>
> Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
>
> I can pick this if no objections.
I have issues with ancestor commits. The most convenient for me would
be probably, if you could send a v2 patch set with both patches and my
tags, and then I can take that to my tree and include it to the next PR.
BR, Jarkko
prev parent reply other threads:[~2024-01-04 19:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-03 15:51 [PATCH] dt-bindings: tpm: Add compatible string atmel,attpm20p Lukas Wunner
2024-01-03 15:54 ` Lukas Wunner
2024-01-04 16:50 ` Jarkko Sakkinen
2024-01-04 18:46 ` Jarkko Sakkinen
2024-01-04 19:11 ` Jarkko Sakkinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CY65RSEA4VMD.MXHPX898TSW4@suppilovahvero \
--to=jarkko@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jgg@ziepe.ca \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-integrity@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=peterhuewe@gmx.de \
--cc=robh+dt@kernel.org \
--cc=tharvey@gateworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).