From: "Jarkko Sakkinen" <jarkko@kernel.org>
To: "Randy Dunlap" <rdunlap@infradead.org>, <linux-kernel@vger.kernel.org>
Cc: "Peter Huewe" <peterhuewe@gmx.de>,
"Jason Gunthorpe" <jgg@ziepe.ca>,
<linux-integrity@vger.kernel.org>
Subject: Re: [PATCH] tpm: cr50: fix kernel-doc warning and spelling
Date: Wed, 03 Jan 2024 15:43:19 +0200 [thread overview]
Message-ID: <CY5465ME87NL.5XCVWIEAJVZW@suppilovahvero> (raw)
In-Reply-To: <20231222061916.9552-1-rdunlap@infradead.org>
On Fri Dec 22, 2023 at 8:19 AM EET, Randy Dunlap wrote:
> Fix kernel-doc notation to prevent a warning:
> tpm_tis_i2c_cr50.c:681: warning: Excess function parameter 'id' description in 'tpm_cr50_i2c_probe'
>
> and fix a spelling error reported by codespell.
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Peter Huewe <peterhuewe@gmx.de>
> Cc: Jarkko Sakkinen <jarkko@kernel.org>
> Cc: Jason Gunthorpe <jgg@ziepe.ca>
> Cc: linux-integrity@vger.kernel.org
> ---
> drivers/char/tpm/tpm_tis_i2c_cr50.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff -- a/drivers/char/tpm/tpm_tis_i2c_cr50.c b/drivers/char/tpm/tpm_tis_i2c_cr50.c
> --- a/drivers/char/tpm/tpm_tis_i2c_cr50.c
> +++ b/drivers/char/tpm/tpm_tis_i2c_cr50.c
> @@ -235,7 +235,7 @@ out:
> * @len: Number of bytes to write.
> *
> * The provided address is prepended to the data in 'buffer', the
> - * cobined address+data is sent to the TPM, then wait for TPM to
> + * combined address+data is sent to the TPM, then wait for TPM to
> * indicate it is done writing.
> *
> * Return:
> @@ -671,7 +671,6 @@ MODULE_DEVICE_TABLE(of, of_cr50_i2c_matc
> /**
> * tpm_cr50_i2c_probe() - Driver probe function.
> * @client: I2C client information.
> - * @id: I2C device id.
> *
> * Return:
> * - 0: Success.
Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@kernel.org>
BR, Jarkko
prev parent reply other threads:[~2024-01-03 13:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-22 6:19 [PATCH] tpm: cr50: fix kernel-doc warning and spelling Randy Dunlap
2024-01-03 13:43 ` Jarkko Sakkinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CY5465ME87NL.5XCVWIEAJVZW@suppilovahvero \
--to=jarkko@kernel.org \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).