From: "Jarkko Sakkinen" <jarkko@kernel.org>
To: "Stefan Berger" <stefanb@linux.ibm.com>,
<linux-integrity@vger.kernel.org>
Cc: <linux-kernel@vger.kernel.org>,
"James Bottomley" <James.Bottomley@HansenPartnership.com>,
"William Roberts" <bill.c.roberts@gmail.com>,
"David Howells" <dhowells@redhat.com>,
"Jason Gunthorpe" <jgg@ziepe.ca>,
"Mimi Zohar" <zohar@linux.ibm.com>,
"Mario Limonciello" <mario.limonciello@amd.com>,
"Jerry Snitselaar" <jsnitsel@redhat.com>
Subject: Re: [PATCH v6 4/8] tpm: Update struct tpm_buf documentation comments
Date: Mon, 04 Dec 2023 04:40:24 +0200 [thread overview]
Message-ID: <CXF7A8PSEKNX.SM7LV367AYHW@suppilovahvero> (raw)
In-Reply-To: <ba84a7c1-f397-45f3-b76c-7faed89a005d@linux.ibm.com>
On Mon Nov 27, 2023 at 10:41 PM EET, Stefan Berger wrote:
>
>
> On 11/23/23 21:02, Jarkko Sakkinen wrote:
> > Remove deprecated portions and document enum values.
> >
> > Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
> > ---
> > v1 [2023-11-21]: A new patch.
> > v2 [2023-11-24]: Refined the commit message a bit.
> > ---
> > include/linux/tpm.h | 9 ++++-----
> > 1 file changed, 4 insertions(+), 5 deletions(-)
> >
> > diff --git a/include/linux/tpm.h b/include/linux/tpm.h
> > index bb0e8718a432..0a8c1351adc2 100644
> > --- a/include/linux/tpm.h
> > +++ b/include/linux/tpm.h
> > @@ -297,15 +297,14 @@ struct tpm_header {
> > };
> > } __packed;
> >
> > -/* A string buffer type for constructing TPM commands. This is based on the
> > - * ideas of string buffer code in security/keys/trusted.h but is heap based
> > - * in order to keep the stack usage minimal.
> > - */
> > -
> > enum tpm_buf_flags {
> > + /* the capacity exceeded: */
>
> was exceeded
+1, agreed a better form :-)
>
> > TPM_BUF_OVERFLOW = BIT(0),
> > };
> >
> > +/*
> > + * A string buffer type for constructing TPM commands.
> > + */
> > struct tpm_buf {
> > unsigned int flags;
> > u8 *data;
>
> Reviewed-by: Stefan Berger <stefanb@linux.ibm.com>
If possible give this to the James' patch set, thank you for the review.
BR, Jarkko
next prev parent reply other threads:[~2023-12-04 2:40 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-24 2:02 [PATCH v6 0/8] Extend struct tpm_buf to support sized buffers (TPM2B) Jarkko Sakkinen
2023-11-24 2:02 ` [PATCH v6 1/8] tpm: Remove unused tpm_buf_tag() Jarkko Sakkinen
2023-11-27 20:33 ` Stefan Berger
2023-11-24 2:02 ` [PATCH v6 2/8] tpm: Remove tpm_send() Jarkko Sakkinen
2023-11-27 20:37 ` Stefan Berger
2023-11-24 2:02 ` [PATCH v6 3/8] tpm: Move buffer handling from static inlines to real functions Jarkko Sakkinen
2023-11-27 20:40 ` Stefan Berger
2023-11-24 2:02 ` [PATCH v6 4/8] tpm: Update struct tpm_buf documentation comments Jarkko Sakkinen
2023-11-27 20:41 ` Stefan Berger
2023-12-04 2:40 ` Jarkko Sakkinen [this message]
2023-11-24 2:02 ` [PATCH v6 5/8] tpm: Store the length of the tpm_buf data separately Jarkko Sakkinen
2023-11-27 21:03 ` Stefan Berger
2023-11-24 2:02 ` [PATCH v6 6/8] tpm: TPM2B formatted buffers Jarkko Sakkinen
2023-11-27 21:08 ` Stefan Berger
2023-11-24 2:02 ` [PATCH v6 7/8] tpm: Add tpm_buf_read_{u8,u16,u32} Jarkko Sakkinen
2023-11-27 21:10 ` Stefan Berger
2023-11-28 12:35 ` Stefan Berger
2023-11-24 2:02 ` [PATCH v6 8/8] KEYS: trusted: tpm2: Use struct tpm_buf for sized buffers Jarkko Sakkinen
2023-11-27 21:21 ` Stefan Berger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CXF7A8PSEKNX.SM7LV367AYHW@suppilovahvero \
--to=jarkko@kernel.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=bill.c.roberts@gmail.com \
--cc=dhowells@redhat.com \
--cc=jgg@ziepe.ca \
--cc=jsnitsel@redhat.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=stefanb@linux.ibm.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).