From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Haener, Michael" <michael.haener@siemens.com>,
"lukas@wunner.de" <lukas@wunner.de>
Cc: "jgg@ziepe.ca" <jgg@ziepe.ca>,
"jarkko@kernel.org" <jarkko@kernel.org>,
"peterhuewe@gmx.de" <peterhuewe@gmx.de>,
"linux-integrity@vger.kernel.org"
<linux-integrity@vger.kernel.org>,
"robh@kernel.org" <robh@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>,
"Sverdlin, Alexander" <alexander.sverdlin@siemens.com>
Subject: Re: [PATCH 2/2] dt-bindings: tpm: Add st,st33ktpm2xi2c to TCG TIS binding
Date: Sun, 14 Apr 2024 07:52:08 +0200 [thread overview]
Message-ID: <8de8590f-0ed3-4fd1-82a3-96b5fb767e48@linaro.org> (raw)
In-Reply-To: <ca685f5b60ac676a72b80b65b73b33d532617acd.camel@siemens.com>
On 14/04/2024 07:42, Haener, Michael wrote:
> On Sat, 2024-04-13 at 13:01 +0200, Krzysztof Kozlowski wrote:
>> On 13/04/2024 12:56, Lukas Wunner wrote:
>>> On Sat, Apr 13, 2024 at 12:53:25PM +0200, Krzysztof Kozlowski
>>> wrote:
>>>> On 13/04/2024 12:51, Lukas Wunner wrote:
>>>>> The binding requires two entries in the compatible string used
>>>>> in the DT,
>>>>> the chip name followed by the generic string:
>>>>>
>>>>> items:
>>>>> - enum:
>>>>> - infineon,slb9673
>>>>> - nuvoton,npct75x
>>>>> - const: tcg,tpm-tis-i2c
>>>>>
>>>>> This allows us to deal with device-specific quirks, should they
>>>>> pop up
>>>>> (e.g. special timing requirements, hardware bugs). We don't
>>>>> know in
>>>>> advance if they will be discovered, but if they are, it's
>>>>> cumbersome
>>>>> to determine after the fact which products (and thus DTs) are
>>>>> affected.
>>>>> So having the name of the actual chip used on the board has
>>>>> value.
>>>>
>>>> So you say devices are compatible. Then the second patch is
>>>> wrong.
>>>>
>>>> I cannot respond to it, though... so NAK-here-for-second-patch.
>>>
>>> I disagree. It's ugly to have inconsistencies between the DT
>>> bindings
>>> and the driver. So I think patch [1/2] in this series is fine.
>>
>> You are mixing different things. This patchset creates inconsistency.
>> You even refer here to bindings while we discuss the driver...
>>
>> Why this one driver is different than all other Linux drivers? Why do
>> you keep pushing here entirely different behavior?
>>
>> The devices are compatible, so growing match table is both redundant
>> and
>> confusing. That's everywhere. TPM is not different.
>>
>> Best regards,
>> Krzysztof
>>
>
> Sorry for the mistakes made (kernel noob).
> I made the patch for the driver analogous to the i2c-tpm of
> infineon,slb9673 and nuvoton,npct75x. In the discussion I realize that
> the compatibility is a duplication and should not be extended.
>
> I now adjust the following in the series:
> - correct cc receiver list
> - delete driver patch with compatibility extension
> - change commit title to "dt-bindings: tpm: Add st,st33ktpm2xi2c"
Thanks.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-04-14 5:52 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-13 7:15 [PATCH 0/2] Add ST33KTPM2XI2C chip to the TPM TIS I2C driver M. Haener
2024-04-13 7:15 ` [PATCH 1/2] tpm: tis_i2c: Add compatible string st,st33ktpm2xi2c M. Haener
2024-04-13 21:45 ` Jarkko Sakkinen
2024-04-13 7:15 ` [PATCH 2/2] dt-bindings: tpm: Add st,st33ktpm2xi2c to TCG TIS binding M. Haener
2024-04-13 8:10 ` Krzysztof Kozlowski
2024-04-13 10:18 ` Lukas Wunner
2024-04-13 10:23 ` Krzysztof Kozlowski
2024-04-13 10:34 ` Lukas Wunner
2024-04-13 10:43 ` Krzysztof Kozlowski
2024-04-13 10:51 ` Lukas Wunner
2024-04-13 10:53 ` Krzysztof Kozlowski
2024-04-13 10:56 ` Lukas Wunner
2024-04-13 11:01 ` Krzysztof Kozlowski
2024-04-14 5:42 ` Haener, Michael
2024-04-14 5:52 ` Krzysztof Kozlowski [this message]
2024-04-13 21:49 ` Jarkko Sakkinen
2024-04-13 8:38 ` Krzysztof Kozlowski
2024-04-13 20:26 ` Haener, Michael
2024-04-13 21:13 ` Krzysztof Kozlowski
2024-04-13 21:47 ` Jarkko Sakkinen
2024-04-13 21:48 ` Krzysztof Kozlowski
2024-04-13 21:50 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8de8590f-0ed3-4fd1-82a3-96b5fb767e48@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alexander.sverdlin@siemens.com \
--cc=conor+dt@kernel.org \
--cc=jarkko@kernel.org \
--cc=jgg@ziepe.ca \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=michael.haener@siemens.com \
--cc=peterhuewe@gmx.de \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).