From: Roberto Sassu <roberto.sassu@huaweicloud.com>
To: Seth Forshee <sforshee@kernel.org>
Cc: zohar@linux.ibm.com, dmitry.kasatkin@gmail.com,
eric.snowberg@oracle.com, paul@paul-moore.com,
jmorris@namei.org, serge@hallyn.com,
linux-integrity@vger.kernel.org,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org,
Roberto Sassu <roberto.sassu@huawei.com>,
stable@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Christian Brauner <brauner@kernel.org>
Subject: Re: [PATCH] evm: Change vfs_getxattr() with __vfs_getxattr() in evm_calc_hmac_or_hash()
Date: Thu, 07 Mar 2024 16:02:20 +0100 [thread overview]
Message-ID: <2dbcd57e3905555b5d966c5403c8f94a307f4990.camel@huaweicloud.com> (raw)
In-Reply-To: <5a08af42118541c87ce0b173d03217c3623adce2.camel@huaweicloud.com>
On Thu, 2024-03-07 at 15:36 +0100, Roberto Sassu wrote:
> On Thu, 2024-03-07 at 08:31 -0600, Seth Forshee wrote:
> > On Thu, Mar 07, 2024 at 01:22:39PM +0100, Roberto Sassu wrote:
> > > From: Roberto Sassu <roberto.sassu@huawei.com>
> > >
> > > Use __vfs_getxattr() instead of vfs_getxattr(), in preparation for
> > > deprecating using the vfs_ interfaces for retrieving fscaps.
> > >
> > > __vfs_getxattr() is only used for debugging purposes, to check if kernel
> > > space and user space see the same xattr value.
> >
> > __vfs_getxattr() won't give you the value as seen by userspace though.
> > Userspace goes through vfs_getxattr() -> xattr_getsecurity() ->
> > cap_inode_getsecurity(), which does the conversion to the value
> > userspace sees. __vfs_getxattr() just gives the raw disk data.
> >
> > I'm also currently working on changes to my fscaps series that will make
> > it so that __vfs_getxattr() also cannot be used to read fscaps xattrs.
> > I'll fix this and other code in EVM which will be broken by that change
> > as part of the next version too.
>
> You are right, thank you!
(Apologies, I should have been more careful).
Roberto
> Roberto
>
> > >
> > > Cc: stable@vger.kernel.org # 5.14.x
> > > Cc: linux-fsdevel@vger.kernel.org
> > > Cc: Christian Brauner <brauner@kernel.org>
> > > Cc: Seth Forshee (DigitalOcean) <sforshee@kernel.org>
> > > Fixes: 907a399de7b0 ("evm: Check xattr size discrepancy between kernel and user")
> > > Signed-off-by: Roberto Sassu <roberto.sassu@huawei.com>
> > > ---
> > > security/integrity/evm/evm_crypto.c | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/security/integrity/evm/evm_crypto.c b/security/integrity/evm/evm_crypto.c
> > > index b1ffd4cc0b44..168d98c63513 100644
> > > --- a/security/integrity/evm/evm_crypto.c
> > > +++ b/security/integrity/evm/evm_crypto.c
> > > @@ -278,8 +278,8 @@ static int evm_calc_hmac_or_hash(struct dentry *dentry,
> > > if (size < 0)
> > > continue;
> > >
> > > - user_space_size = vfs_getxattr(&nop_mnt_idmap, dentry,
> > > - xattr->name, NULL, 0);
> > > + user_space_size = __vfs_getxattr(dentry, inode, xattr->name,
> > > + NULL, 0);
> > > if (user_space_size != size)
> > > pr_debug("file %s: xattr %s size mismatch (kernel: %d, user: %d)\n",
> > > dentry->d_name.name, xattr->name, size,
> > > --
> > > 2.34.1
> > >
prev parent reply other threads:[~2024-03-07 15:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-07 12:22 [PATCH] evm: Change vfs_getxattr() with __vfs_getxattr() in evm_calc_hmac_or_hash() Roberto Sassu
2024-03-07 14:31 ` Seth Forshee
2024-03-07 14:36 ` Roberto Sassu
2024-03-07 15:02 ` Roberto Sassu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2dbcd57e3905555b5d966c5403c8f94a307f4990.camel@huaweicloud.com \
--to=roberto.sassu@huaweicloud.com \
--cc=brauner@kernel.org \
--cc=dmitry.kasatkin@gmail.com \
--cc=eric.snowberg@oracle.com \
--cc=jmorris@namei.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=roberto.sassu@huawei.com \
--cc=serge@hallyn.com \
--cc=sforshee@kernel.org \
--cc=stable@vger.kernel.org \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).