From: Lukas Wunner <lukas@wunner.de>
To: Jarkko Sakkinen <jarkko@kernel.org>
Cc: Peter Huewe <peterhuewe@gmx.de>, Jason Gunthorpe <jgg@ziepe.ca>,
Tim Harvey <tharvey@gateworks.com>,
linux-integrity@vger.kernel.org
Subject: Re: [PATCH] tpm_tis_spi: Add compatible string atmel,attpm20p
Date: Wed, 3 Jan 2024 17:10:36 +0100 [thread overview]
Message-ID: <20240103161036.GA21138@wunner.de> (raw)
In-Reply-To: <CY54GMOIMYHU.3BTC0MFJZ4XAK@suppilovahvero>
On Wed, Jan 03, 2024 at 03:57:00PM +0200, Jarkko Sakkinen wrote:
> On Wed Jan 3, 2024 at 3:53 PM EET, Jarkko Sakkinen wrote:
> > On Sat Dec 23, 2023 at 11:34 AM EET, Lukas Wunner wrote:
> > > Commit 4f2a348aa365 ("arm64: dts: imx8mm-venice-gw73xx: add TPM device")
> > > added a devicetree node for the Trusted Platform Module on certain
> > > Gateworks boards.
> > >
> > > The commit only used the generic "tcg,tpm_tis-spi" compatible string,
> > > but public documentation shows that the chip is an ATTPM20P from Atmel
> > > (nowadays Microchip):
> > > https://trac.gateworks.com/wiki/tpm
> > >
> > > Add the chip to the supported compatible strings of the TPM TIS SPI
> > > driver.
[...]
> > > --- a/drivers/char/tpm/tpm_tis_spi_main.c
> > > +++ b/drivers/char/tpm/tpm_tis_spi_main.c
> > > @@ -327,6 +327,7 @@ static const struct spi_device_id tpm_tis_spi_id[] = {
> > > MODULE_DEVICE_TABLE(spi, tpm_tis_spi_id);
> > >
> > > static const struct of_device_id of_tis_spi_match[] __maybe_unused = {
> > > + { .compatible = "atmel,attpm20p", .data = tpm_tis_spi_probe },
> > > { .compatible = "st,st33htpm-spi", .data = tpm_tis_spi_probe },
> > > { .compatible = "infineon,slb9670", .data = tpm_tis_spi_probe },
> > > { .compatible = "tcg,tpm_tis-spi", .data = tpm_tis_spi_probe },
> >
> > Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@kernel.org>
>
> Taking this back as checkpatch gives warning:
>
> WARNING: DT compatible string "atmel,attpm20p" appears un-documented -- check ./Documentation/devicetree/bindings/
> #36: FILE: drivers/char/tpm/tpm_tis_spi_main.c:330:
> + { .compatible = "atmel,attpm20p", .data = tpm_tis_spi_probe },
Yes, sorry for the confusion.
Before applying this patch, you'd first have to pick up this series
to clean up TPM dt-bindings (it has a Reviewed-by from Rob):
https://lore.kernel.org/all/cover.1702806810.git.lukas@wunner.de/
Plus the following patch I just submitted which adds "atmel,attpm20p"
to the dt-bindings (feel free to squash with the patch "dt-bindings:
tpm: Consolidate TCG TIS bindings" in the above-linked series):
https://lore.kernel.org/all/20240103155414.93-qGU4jYFy5x6c0EXMdyw2SO2Vyz5tChxsDLbWzSFE@z/
Note that there are two other patches pending to add missing compatible
strings to the driver, but they likewise depend on the above-linked
series to clean up TPM dt-bindings:
https://lore.kernel.org/all/096e5d9d22eaed0a256d2d9b315a77245bd423c6.1701095446.git.lukas@wunner.de/
https://lore.kernel.org/all/5c92620082189dc4e6be277952d0b46df26a6478.1702811113.git.lukas@wunner.de/
Thanks,
Lukas
prev parent reply other threads:[~2024-01-03 16:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-23 9:34 [PATCH] tpm_tis_spi: Add compatible string atmel,attpm20p Lukas Wunner
2024-01-03 13:53 ` Jarkko Sakkinen
2024-01-03 13:57 ` Jarkko Sakkinen
2024-01-03 16:10 ` Lukas Wunner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240103161036.GA21138@wunner.de \
--to=lukas@wunner.de \
--cc=jarkko@kernel.org \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=tharvey@gateworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).