From: Stefan Berger <stefanb@linux.ibm.com>
To: linux-integrity@vger.kernel.org
Cc: zohar@linux.ibm.com, Stefan Berger <stefanb@linux.ibm.com>
Subject: [ima-evm-utils PATCH v2 00/14] Enable shellcheck and fix some issues
Date: Tue, 28 Nov 2023 13:15:58 -0500 [thread overview]
Message-ID: <20231128181613.1159958-1-stefanb@linux.ibm.com> (raw)
Enable shellcheck for the bash scripts in the tests directory. Fix issues
on the way that are found when particular checks are enabled. In the end
all shellcheck v0.9 checks are enabled and shellcheck passes without any
issues.
Shellcheck can be run using the following command:
make shellcheck
Apart from style issues two real issues are detected by SC2003 and SC2295.
Regards,
Stefan
v2:
- Rebased on latest next-testing branch
- 1/14: Use ${var:+${var}} pattern for variables that hold multiple
arguments like "--foo bar" which would become one argument
if passed with "${var}"; fixed a build issue
- 4/14: remove $new_policy file in success and failure cases
Stefan Berger (14):
tests: Address issues raised by shellcheck SC2086 & enable shellcheck
tests: Address issues raised by shellcheck SC2181
tests: Address issues raised by shellcheck SC2046
tests: Address issues raised by shellcheck SC2320
tests: Address issues raised by shellcheck SC2317
tests: Address issues raised by shellcheck SC2034
tests: Address issues raised by shellcheck SC2164
tests: Address issues raised by shellcheck SC2166
tests: Address issues raised by shellcheck SC2294
tests: Address issues raised by shellcheck SC2206
tests: Address issues raised by shellcheck SC2196
tests: Address issues raised by shellcheck SC2043
tests: Address issues raised by shellcheck SC2295
tests: Address issues raised by shellcheck SC2003
Makefile.am | 5 ++-
tests/Makefile.am | 11 ++++++-
tests/boot_aggregate.test | 28 +++++++---------
tests/fsverity.test | 22 +++++++------
tests/functions.sh | 36 ++++++++++----------
tests/gen-keys.sh | 8 +++--
tests/ima_hash.test | 4 +--
tests/install-fsverity.sh | 4 +--
tests/install-mount-idmapped.sh | 2 +-
tests/install-openssl3.sh | 14 ++++----
tests/install-swtpm.sh | 9 ++---
tests/install-tss.sh | 2 +-
tests/mmap_check.test | 10 +++---
tests/portable_signatures.test | 11 +++----
tests/sign_verify.test | 15 ++++-----
tests/softhsm_setup | 58 ++++++++++++++-------------------
16 files changed, 119 insertions(+), 120 deletions(-)
--
2.43.0
next reply other threads:[~2023-11-28 18:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-28 18:15 Stefan Berger [this message]
2023-11-28 18:15 ` [ima-evm-utils PATCH v2 01/14] tests: Address issues raised by shellcheck SC2086 & enable shellcheck Stefan Berger
2023-11-28 18:16 ` [ima-evm-utils PATCH v2 02/14] tests: Address issues raised by shellcheck SC2181 Stefan Berger
2023-11-28 18:16 ` [ima-evm-utils PATCH v2 03/14] tests: Address issues raised by shellcheck SC2046 Stefan Berger
2023-11-28 18:16 ` [ima-evm-utils PATCH v2 04/14] tests: Address issues raised by shellcheck SC2320 Stefan Berger
2023-11-28 18:16 ` [ima-evm-utils PATCH v2 05/14] tests: Address issues raised by shellcheck SC2317 Stefan Berger
2023-11-28 18:16 ` [ima-evm-utils PATCH v2 06/14] tests: Address issues raised by shellcheck SC2034 Stefan Berger
2023-11-28 18:16 ` [ima-evm-utils PATCH v2 07/14] tests: Address issues raised by shellcheck SC2164 Stefan Berger
2023-11-28 18:16 ` [ima-evm-utils PATCH v2 08/14] tests: Address issues raised by shellcheck SC2166 Stefan Berger
2023-11-28 18:16 ` [ima-evm-utils PATCH v2 09/14] tests: Address issues raised by shellcheck SC2294 Stefan Berger
2023-11-28 18:16 ` [ima-evm-utils PATCH v2 10/14] tests: Address issues raised by shellcheck SC2206 Stefan Berger
2023-11-28 18:16 ` [ima-evm-utils PATCH v2 11/14] tests: Address issues raised by shellcheck SC2196 Stefan Berger
2023-11-28 18:16 ` [ima-evm-utils PATCH v2 12/14] tests: Address issues raised by shellcheck SC2043 Stefan Berger
2023-11-28 18:16 ` [ima-evm-utils PATCH v2 13/14] tests: Address issues raised by shellcheck SC2295 Stefan Berger
2023-11-28 18:16 ` [ima-evm-utils PATCH v2 14/14] tests: Address issues raised by shellcheck SC2003 Stefan Berger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231128181613.1159958-1-stefanb@linux.ibm.com \
--to=stefanb@linux.ibm.com \
--cc=linux-integrity@vger.kernel.org \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).