From: Jiri Kosina <jikos@kernel.org>
To: Martino Fontana <tinozzo123@gmail.com>
Cc: djogorchock@gmail.com, benjamin.tissoires@redhat.com,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Ryan McClelland <rymcclel@gmail.com>
Subject: Re: [PATCH v3 RESEND] HID: nintendo: use ida for LED player id
Date: Wed, 3 Apr 2024 13:26:52 +0200 (CEST) [thread overview]
Message-ID: <nycvar.YFH.7.76.2404031326430.20263@cbobk.fhfr.pm> (raw)
In-Reply-To: <20240318110145.18490-1-tinozzo123@gmail.com>
On Mon, 18 Mar 2024, Martino Fontana wrote:
> Previously, the leds pattern would just increment with every controller
> connected. This wouldn't take into consideration when controllers are
> disconnected. The same controller could be connected and disconnected
> with the pattern increasing player count each time.
>
> This patch changes it by using an ID allocator in order to assign the
> player id, the same way hid-playstation does.
>
> Signed-off-by: Martino Fontana <tinozzo123@gmail.com>
> Signed-off-by: Ryan McClelland <rymcclel@gmail.com>
> ---
> Changes for v2:
>
> ida_free now frees the correct id, instead of an id that got moduloed.
>
> Changes for v3:
>
> Destroy allocator when removing driver.
Applied, thanks.
--
Jiri Kosina
SUSE Labs
prev parent reply other threads:[~2024-04-03 11:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-18 10:36 [PATCH v3 RESEND] HID: nintendo: use ida for LED player id Martino Fontana
2024-04-03 11:26 ` Jiri Kosina [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.76.2404031326430.20263@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=djogorchock@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rymcclel@gmail.com \
--cc=tinozzo123@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).