From: Jiri Kosina <jikos@kernel.org>
To: Nuno Pereira <nf.pereira@outlook.pt>
Cc: "linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
Daniel Ogorchock <djogorchock@gmail.com>,
Ryan McClelland <rymcclel@gmail.com>,
"benjamin.tissoires@redhat.com" <benjamin.tissoires@redhat.com>
Subject: Re: [PATCH] HID: nintendo: Fix N64 controller being identified as mouse
Date: Wed, 3 Apr 2024 13:19:44 +0200 (CEST) [thread overview]
Message-ID: <nycvar.YFH.7.76.2404031319370.20263@cbobk.fhfr.pm> (raw)
In-Reply-To: <DU0P189MB2044EAF345CB76578D8C1A5CFD5A2@DU0P189MB2044.EURP189.PROD.OUTLOOK.COM>
On Mon, 26 Feb 2024, Nuno Pereira wrote:
> This patch is regarding the recent addition of support for the NSO
> controllers to hid-nintendo. All controllers are working correctly with the
> exception of the N64 controller, which is being identified as a mouse by
> udev. This results in the joystick controlling the mouse cursor and the
> controller not being detected by games.
>
> The reason for this is because the N64's C buttons have been attributed to
> BTN_FORWARD, BTN_BACK, BTN_LEFT, BTN_RIGHT, which are buttons typically
> attributed to mice.
>
> This patch changes those buttons to controller buttons, making the
> controller be correctly identified as such.
>
> Signed-off-by: Nuno Pereira <nf.pereira@outlook.pt>
Applied, thanks.
--
Jiri Kosina
SUSE Labs
next prev parent reply other threads:[~2024-04-03 11:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-26 22:39 [PATCH] HID: nintendo: Fix N64 controller being identified as mouse Nuno Pereira
2024-03-22 11:02 ` Jiri Kosina
2024-03-22 17:06 ` Nuno Pereira
2024-04-03 11:19 ` Jiri Kosina [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-02-14 21:36 Nuno Pereira
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.76.2404031319370.20263@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=djogorchock@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=nf.pereira@outlook.pt \
--cc=rymcclel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).