From: Allen Lin <allencl_lin@hotmail.com>
To: Jiri Kosina <jikos@kernel.org>
Cc: dmitry.torokhov@gmail.com, robh@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor@kernel.org,
benjamin.tissoires@redhat.com, linux-input@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/4] HID: Add support for Himax HX83102j touchscreen
Date: Wed, 10 Apr 2024 10:58:13 +0800 [thread overview]
Message-ID: <TY0PR06MB5611D1BC58464EEE3AF612DE9E062@TY0PR06MB5611.apcprd06.prod.outlook.com> (raw)
In-Reply-To: <nycvar.YFH.7.76.2404031347540.20263@cbobk.fhfr.pm>
Jiri Kosina <jikos@kernel.org> 於 2024年4月3日 週三 下午7:48寫道：
>
> On Tue, 2 Apr 2024, Allen_Lin wrote:
>
> > Hi,
> > This driver implements for Himax HID touchscreen HX83102j.
> >
> > Using SPI interface to receive/send HID packets.
> >
> > Changes in v2 :
> > -Added power description in YAML document.
> > -Added ddreset-gpios property in YAML document.
> > -Added firmware-name property in YAML document.
> > -Modified the description of pid.
> > -Modified the example.
> >
> > Allen_Lin (4):
> > dt-bindings: input: Add Himax HX83102J touchscreen
> > HID: Add Himax HX83102J touchscreen driver
> > HID: Add DRM panel follower function
> > HID: Load firmware directly from file to IC
> >
> > .../input/touchscreen/himax,hx83102j.yaml | 100 +
> > MAINTAINERS | 7 +
> > drivers/hid/Kconfig | 7 +
> > drivers/hid/Makefile | 2 +
> > drivers/hid/hid-himax-83102j.c | 3071 +++++++++++++++++
> > drivers/hid/hid-himax-83102j.h | 460 +++
>
> My only nit here -- could we please call the driver just hid-himax, to
> follow the pattern we generally use in this subsystem (drivers named after
> vendors).
>
83102j is our IC name, we add it to our driver name to distinguish
different ICs,
Can we just reserve this in driver name?
Thanks
Allen
> Please add Ack from Rob, rename the driver, resend, and I'll apply it.
> Thanks,
>
> --
> Jiri Kosina
> SUSE Labs
>
prev parent reply other threads:[~2024-04-10 2:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-02 10:49 [PATCH v2 0/4] HID: Add support for Himax HX83102j touchscreen Allen_Lin
2024-04-03 11:48 ` Jiri Kosina
2024-04-10 2:58 ` Allen Lin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=TY0PR06MB5611D1BC58464EEE3AF612DE9E062@TY0PR06MB5611.apcprd06.prod.outlook.com \
--to=allencl_lin@hotmail.com \
--cc=benjamin.tissoires@redhat.com \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=jikos@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).