From: Kenny Levinsen <kl@kl.wtf>
To: Jiri Kosina <jikos@kernel.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: Douglas Anderson <dianders@chromium.org>,
Hans de Goede <hdegoede@redhat.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: i2c-hid: Revert to await reset ACK before reading report descriptor
Date: Sun, 31 Mar 2024 20:23:03 +0200 [thread overview]
Message-ID: <4fe2450a-51ca-4161-9006-1325c2a16c07@kl.wtf> (raw)
In-Reply-To: <20240331132332.6694-1-kl@kl.wtf>
On 3/31/24 3:23 PM, Kenny Levinsen wrote:
> diff --git a/drivers/hid/i2c-hid/i2c-hid-core.c b/drivers/hid/i2c-hid/i2c-hid-core.c
> index 2df1ab3c31cc..be5d661dde41 100644
> --- a/drivers/hid/i2c-hid/i2c-hid-core.c
> +++ b/drivers/hid/i2c-hid/i2c-hid-core.c
> @@ -737,7 +737,9 @@ static int i2c_hid_parse(struct hid_device *hid)
> ret = i2c_hid_start_hwreset(ihid);
> if (ret)
> msleep(1000);
> + ret = i2c_hid_finish_hwreset(ihid);
Ah, missed the check to only call i2c_hid_finish_hwreset if
i2c_hid_start_hwreset succeeded, v2 incoming.
prev parent reply other threads:[~2024-03-31 18:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-31 13:23 [PATCH] HID: i2c-hid: Revert to await reset ACK before reading report descriptor Kenny Levinsen
2024-03-31 18:23 ` Kenny Levinsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4fe2450a-51ca-4161-9006-1325c2a16c07@kl.wtf \
--to=kl@kl.wtf \
--cc=benjamin.tissoires@redhat.com \
--cc=dianders@chromium.org \
--cc=hdegoede@redhat.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).