From: Andreas Kemnade <andreas@kemnade.info>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: dmitry.torokhov@gmail.com, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, u.kleine-koenig@pengutronix.de,
hdegoede@redhat.com, siebren.vroegindeweij@hotmail.com,
linux-input@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] Input: ektf2127 - add ektf2232 support
Date: Mon, 6 May 2024 22:29:16 +0200 [thread overview]
Message-ID: <20240506222916.055443d8@aktux> (raw)
In-Reply-To: <CAHp75VchLWQgmdxKPSbwH-m43zFHT9ADk4aH7-jvD5-MaVOtEw@mail.gmail.com>
On Mon, 6 May 2024 21:43:14 +0300
Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> On Mon, May 6, 2024 at 7:21 PM Andreas Kemnade <andreas@kemnade.info> wrote:
> > On Mon, 6 May 2024 15:05:52 +0300
> > Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> > > From: Andy Shevchenko <andy.shevchenko@gmail.com>
> > > To: Andreas Kemnade <andreas@kemnade.info>
> > > Date: Mon, 6 May 2024 15:05:52 +0300
> > > On Mon, May 6, 2024 at 12:48 AM Andreas Kemnade <andreas@kemnade.info> wrote:
>
> ...
>
> > > I'm wondering if you are using --histogram diff algo when preparing the patches.
> >
> > No, I am not using that, it seems to not make that chunk nicer.
> > Yes, we want
> >
> > + int status_shift;
> > };
> > +
> > +struct ektf2127_i2c_chip_data {
> > + int status_shift;
> > +};
> >
> > But that is not shorter or simpler, just more readable.
>
> And that's exactly what histogram is about. I suggest making it
> default for the Linux kernel project (or globally in your
> ~/.gitconfig).
>
>
again, it does not do anything helpful in this case, I tried to run
git format-patch --histogram with
no improvements. But it might help in other places.
Regards,
Andreas
prev parent reply other threads:[~2024-05-06 20:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-05 21:47 [PATCH v2 0/3] Input: Add ektf2232 support Andreas Kemnade
2024-05-05 21:47 ` [PATCH v2 1/3] dt-bindings: touchscreen: convert elan,ektf2127 to json-schema Andreas Kemnade
2024-05-06 6:24 ` Krzysztof Kozlowski
2024-05-05 21:47 ` [PATCH v2 2/3] dt-bindings: touchscreen: elan,ektf2127: Add EKTF2232 Andreas Kemnade
2024-05-06 6:24 ` Krzysztof Kozlowski
2024-05-05 21:47 ` [PATCH v2 3/3] Input: ektf2127 - add ektf2232 support Andreas Kemnade
2024-05-06 12:05 ` Andy Shevchenko
2024-05-06 16:21 ` Andreas Kemnade
2024-05-06 18:43 ` Andy Shevchenko
2024-05-06 20:29 ` Andreas Kemnade [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240506222916.055443d8@aktux \
--to=andreas@kemnade.info \
--cc=andy.shevchenko@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=hdegoede@redhat.com \
--cc=krzk+dt@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=siebren.vroegindeweij@hotmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).