From: Charles Wang <charles.goodix@gmail.com>
To: hadess@hadess.net, hdegoede@redhat.com, dmitry.torokhov@gmail.com
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
neil.armstrong@linaro.org, charles.goodix@gmail.com
Subject: [PATCH] Input: goodix-berlin - Add sysfs interface for reading and writing touch IC registers
Date: Mon, 6 May 2024 19:47:52 +0800 [thread overview]
Message-ID: <20240506114752.47204-1-charles.goodix@gmail.com> (raw)
Export a sysfs interface that would allow reading and writing touchscreen
IC registers. With this interface many things can be done in usersapce
such as firmware updates. An example tool that utilizes this interface
for performing firmware updates can be found at [1].
[1] https://github.com/goodix/fwupdate_for_berlin_linux
Signed-off-by: Charles Wang <charles.goodix@gmail.com>
---
drivers/input/touchscreen/goodix_berlin.h | 2 +
.../input/touchscreen/goodix_berlin_core.c | 52 +++++++++++++++++++
drivers/input/touchscreen/goodix_berlin_i2c.c | 6 +++
drivers/input/touchscreen/goodix_berlin_spi.c | 6 +++
4 files changed, 66 insertions(+)
diff --git a/drivers/input/touchscreen/goodix_berlin.h b/drivers/input/touchscreen/goodix_berlin.h
index 1fd77eb69..1741f2d15 100644
--- a/drivers/input/touchscreen/goodix_berlin.h
+++ b/drivers/input/touchscreen/goodix_berlin.h
@@ -19,6 +19,8 @@ struct regmap;
int goodix_berlin_probe(struct device *dev, int irq, const struct input_id *id,
struct regmap *regmap);
+void goodix_berlin_remove(struct device *dev);
+
extern const struct dev_pm_ops goodix_berlin_pm_ops;
#endif
diff --git a/drivers/input/touchscreen/goodix_berlin_core.c b/drivers/input/touchscreen/goodix_berlin_core.c
index e7b41a926..e02160841 100644
--- a/drivers/input/touchscreen/goodix_berlin_core.c
+++ b/drivers/input/touchscreen/goodix_berlin_core.c
@@ -672,6 +672,44 @@ static void goodix_berlin_power_off_act(void *data)
goodix_berlin_power_off(cd);
}
+static ssize_t goodix_berlin_registers_read(struct file *filp, struct kobject *kobj,
+ struct bin_attribute *bin_attr, char *buf, loff_t off, size_t count)
+{
+ struct goodix_berlin_core *cd;
+ struct device *dev;
+ int error;
+
+ dev = kobj_to_dev(kobj);
+ cd = dev_get_drvdata(dev);
+
+ error = regmap_raw_read(cd->regmap, (unsigned int)off,
+ buf, count);
+
+ return error ? error : count;
+}
+
+static ssize_t goodix_berlin_registers_write(struct file *filp, struct kobject *kobj,
+ struct bin_attribute *bin_attr, char *buf, loff_t off, size_t count)
+{
+ struct goodix_berlin_core *cd;
+ struct device *dev;
+ int error;
+
+ dev = kobj_to_dev(kobj);
+ cd = dev_get_drvdata(dev);
+
+ error = regmap_raw_write(cd->regmap, (unsigned int)off,
+ buf, count);
+
+ return error ? error : count;
+}
+
+static struct bin_attribute goodix_berlin_registers_attr = {
+ .attr = {.name = "registers", .mode = 0600},
+ .read = goodix_berlin_registers_read,
+ .write = goodix_berlin_registers_write,
+};
+
int goodix_berlin_probe(struct device *dev, int irq, const struct input_id *id,
struct regmap *regmap)
{
@@ -743,6 +781,14 @@ int goodix_berlin_probe(struct device *dev, int irq, const struct input_id *id,
dev_set_drvdata(dev, cd);
+ error = sysfs_create_bin_file(&cd->dev->kobj,
+ &goodix_berlin_registers_attr);
+
+ if (error) {
+ dev_err(dev, "unable to create sysfs file, err=%d\n", error);
+ return error;
+ }
+
dev_dbg(dev, "Goodix Berlin %s Touchscreen Controller",
cd->fw_version.patch_pid);
@@ -750,6 +796,12 @@ int goodix_berlin_probe(struct device *dev, int irq, const struct input_id *id,
}
EXPORT_SYMBOL_GPL(goodix_berlin_probe);
+void goodix_berlin_remove(struct device *dev)
+{
+ sysfs_remove_bin_file(&dev->kobj, &goodix_berlin_registers_attr);
+}
+EXPORT_SYMBOL_GPL(goodix_berlin_remove);
+
MODULE_LICENSE("GPL");
MODULE_DESCRIPTION("Goodix Berlin Core Touchscreen driver");
MODULE_AUTHOR("Neil Armstrong <neil.armstrong@linaro.org>");
diff --git a/drivers/input/touchscreen/goodix_berlin_i2c.c b/drivers/input/touchscreen/goodix_berlin_i2c.c
index 6ed9aa808..35ef21cc8 100644
--- a/drivers/input/touchscreen/goodix_berlin_i2c.c
+++ b/drivers/input/touchscreen/goodix_berlin_i2c.c
@@ -46,6 +46,11 @@ static int goodix_berlin_i2c_probe(struct i2c_client *client)
return 0;
}
+static void goodix_berlin_i2c_remove(struct i2c_client *client)
+{
+ goodix_berlin_remove(&client->dev);
+}
+
static const struct i2c_device_id goodix_berlin_i2c_id[] = {
{ "gt9916", 0 },
{ }
@@ -66,6 +71,7 @@ static struct i2c_driver goodix_berlin_i2c_driver = {
.pm = pm_sleep_ptr(&goodix_berlin_pm_ops),
},
.probe = goodix_berlin_i2c_probe,
+ .remove = goodix_berlin_i2c_remove,
.id_table = goodix_berlin_i2c_id,
};
module_i2c_driver(goodix_berlin_i2c_driver);
diff --git a/drivers/input/touchscreen/goodix_berlin_spi.c b/drivers/input/touchscreen/goodix_berlin_spi.c
index 4cc557da0..8ffbe1289 100644
--- a/drivers/input/touchscreen/goodix_berlin_spi.c
+++ b/drivers/input/touchscreen/goodix_berlin_spi.c
@@ -150,6 +150,11 @@ static int goodix_berlin_spi_probe(struct spi_device *spi)
return 0;
}
+static void goodix_berlin_spi_remove(struct spi_device *spi)
+{
+ goodix_berlin_remove(&spi->dev);
+}
+
static const struct spi_device_id goodix_berlin_spi_ids[] = {
{ "gt9916" },
{ },
@@ -169,6 +174,7 @@ static struct spi_driver goodix_berlin_spi_driver = {
.pm = pm_sleep_ptr(&goodix_berlin_pm_ops),
},
.probe = goodix_berlin_spi_probe,
+ .remove = goodix_berlin_spi_remove,
.id_table = goodix_berlin_spi_ids,
};
module_spi_driver(goodix_berlin_spi_driver);
--
2.43.0
next reply other threads:[~2024-05-06 11:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-06 11:47 Charles Wang [this message]
2024-05-06 12:03 ` [PATCH] Input: goodix-berlin - Add sysfs interface for reading and writing touch IC registers Hans de Goede
2024-05-06 13:20 ` Richard Hughes
2024-05-07 2:13 ` Dmitry Torokhov
2024-05-07 6:29 ` neil.armstrong
2024-05-07 8:25 ` Hans de Goede
2024-05-07 12:19 ` Charles Wang
2024-05-07 12:38 ` Hans de Goede
2024-05-07 14:36 ` Mark Brown
2024-05-07 15:14 ` Jeff LaBundy
2024-05-07 21:09 ` Dmitry Torokhov
2024-05-08 2:37 ` Mark Brown
2024-05-08 8:39 ` Richard Hughes
2024-05-08 11:47 ` Mark Brown
2024-05-07 12:12 ` Charles Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240506114752.47204-1-charles.goodix@gmail.com \
--to=charles.goodix@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=hadess@hadess.net \
--cc=hdegoede@redhat.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).