From: Conor Dooley <conor@kernel.org>
To: Allen Lin <allencl_lin@hotmail.com>
Cc: Conor Dooley <conor.dooley@microchip.com>,
Rob Herring <robh@kernel.org>,
dmitry.torokhov@gmail.com, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, jikos@kernel.org,
benjamin.tissoires@redhat.com, linux-input@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/4] dt-bindings: input: Add Himax HX83102J touchscreen
Date: Thu, 28 Mar 2024 18:05:41 +0000 [thread overview]
Message-ID: <20240328-aggregate-greasily-9d57e3ebf3ce@spud> (raw)
In-Reply-To: <TY0PR06MB5611F7123B22C4FDEE319C049E3B2@TY0PR06MB5611.apcprd06.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 1145 bytes --]
On Thu, Mar 28, 2024 at 02:05:17PM +0800, Allen Lin wrote:
> OK, I will list all supplies required by the driver in the Yaml
> document as shown below,
>
> properties:
> compatible:
> const: himax,hx83102j
>
> reg:
> maxItems: 1
>
> interrupts:
> maxItems: 1
>
> reset-gpios:
> maxItems: 1
>
> vccd-supply:
> description: A phandle for the regualtor supplying IO power.
>
> vsn-supply:
> description: Negative supply regulator.
>
> vsp-supply:
> description: Positive supply regulator.
>
> ddreset-gpios:
I think this should be s/dd// with the description explaining how this
display reset is related to this device.
Otherwise, this looks okay to me.
On another note - every time you reply to me I get it 3 times. Can you
fix that please?
Thanks,
Conor.
> description: A phandle of gpio for display reset controlled by the
> LCD driver.
>
> required:
> - compatible
> - reg
> - interrupts
> - reset-gpios
> - panel
> - vccd-supply
> - vsn-supply
> - vsp-supply
> - ddreset-gpios
>
>
> Thanks,
> Allen
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2024-03-28 18:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240322085606.993896-1-allencl_lin@hotmail.com>
2024-03-22 8:56 ` [PATCH v1 1/4] dt-bindings: input: Add Himax HX83102J touchscreen Allen_Lin
2024-03-22 17:54 ` Conor Dooley
2024-03-22 18:30 ` Rob Herring
2024-03-22 18:34 ` Conor Dooley
2024-03-26 5:46 ` Allen Lin
2024-03-26 8:48 ` Conor Dooley
2024-03-26 10:40 ` Allen Lin
2024-03-26 19:28 ` Conor Dooley
2024-03-27 7:48 ` Allen Lin
2024-03-27 16:44 ` Conor Dooley
2024-03-28 6:05 ` Allen Lin
2024-03-28 18:05 ` Conor Dooley [this message]
2024-03-22 18:31 ` Rob Herring
2024-03-22 8:56 ` [PATCH v1 2/4] HID: Add Himax HX83102J touchscreen driver Allen_Lin
2024-03-22 8:56 ` [PATCH v1 3/4] HID: Add DRM panel follower function Allen_Lin
2024-03-22 8:56 ` [PATCH v1 4/4] HID: Load firmware directly from file to IC Allen_Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240328-aggregate-greasily-9d57e3ebf3ce@spud \
--to=conor@kernel.org \
--cc=allencl_lin@hotmail.com \
--cc=benjamin.tissoires@redhat.com \
--cc=conor+dt@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=jikos@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).