From: "Nuno Sá" <noname.nuno@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>,
Nuno Sa via B4 Relay <devnull+nuno.sa.analog.com@kernel.org>
Cc: nuno.sa@analog.com, linux-kernel@vger.kernel.org,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Olivier Moysan <olivier.moysan@foss.st.com>,
Jyoti Bhayana <jbhayana@google.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: Re: [PATCH v4 0/6] iio: temperature: ltc2983: small improvements
Date: Thu, 28 Mar 2024 18:07:21 +0100 [thread overview]
Message-ID: <f0f985b272af85aea912479ced50ff52f29506b1.camel@gmail.com> (raw)
In-Reply-To: <20240328165650.1d8d4216@jic23-huawei>
On Thu, 2024-03-28 at 16:56 +0000, Jonathan Cameron wrote:
> On Thu, 28 Mar 2024 17:22:00 +0100
> Nuno Sa via B4 Relay <devnull+nuno.sa.analog.com@kernel.org> wrote:
>
> > The v4 introduces an new dev_errp_probe() helper to deal with cases
> > where we want to return error pointers. The refactor in the IIO ltc2983
> > is an heavy user of the pattern and was the main motivation for this.
> >
> > Also added two new patches so we have three users of the new
> > dev_errp_probe() helper.
>
> Probably better to do this as 2 series. The other ltc2983 changes in one series
> and one with a cover letter title that will get noticed by
> those who care about dev_printk helpers.
>
That makes sense, yes.
- Nuno Sá
> From a quick look the content of the patches is fine.
>
> Jonathan
>
> >
> > ---
> > Changes in v4:
> > - Link to v3:
> > https://lore.kernel.org/r/20240301-ltc2983-misc-improv-v3-0-c09516ac0efc@analog.com
> > - Patch 1
> > * New patch
> > - Patch 2
> > * Use dev_errp_probe() instead of local variant
> > - Patch 5
> > * New patch
> > - Patch 6
> > * New patch
> >
> > ---
> > Nuno Sa (6):
> > printk: add new dev_errp_probe() helper
> > iio: temperature: ltc2983: convert to dev_err_probe()
> > dt-bindings: iio: temperature: ltc2983: document power supply
> > iio: temperature: ltc2983: support vdd regulator
> > iio: backend: make use dev_errp_probe()
> > iio: common: scmi_iio: convert to dev_err_probe()
> >
> > .../bindings/iio/temperature/adi,ltc2983.yaml | 4 +
> > drivers/iio/common/scmi_sensors/scmi_iio.c | 45 ++--
> > drivers/iio/industrialio-backend.c | 8 +-
> > drivers/iio/temperature/ltc2983.c | 260 ++++++++++-----------
> > include/linux/dev_printk.h | 5 +
> > 5 files changed, 151 insertions(+), 171 deletions(-)
> > ---
> > base-commit: 27eea4778db8268cd6dc80a5b853c599bd3099f1
> > change-id: 20240227-ltc2983-misc-improv-d9c4a3819b1f
> > --
> >
> > Thanks!
> > - Nuno Sá
> >
> >
>
prev parent reply other threads:[~2024-03-28 17:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-28 16:22 [PATCH v4 0/6] iio: temperature: ltc2983: small improvements Nuno Sa via B4 Relay
2024-03-28 16:22 ` [PATCH v4 1/6] printk: add new dev_errp_probe() helper Nuno Sa via B4 Relay
2024-03-28 16:22 ` [PATCH v4 2/6] iio: temperature: ltc2983: convert to dev_err_probe() Nuno Sa via B4 Relay
2024-03-28 16:22 ` [PATCH v4 3/6] dt-bindings: iio: temperature: ltc2983: document power supply Nuno Sa via B4 Relay
2024-03-28 16:22 ` [PATCH v4 4/6] iio: temperature: ltc2983: support vdd regulator Nuno Sa via B4 Relay
2024-03-28 16:22 ` [PATCH v4 5/6] iio: backend: make use dev_errp_probe() Nuno Sa via B4 Relay
2024-03-28 16:22 ` [PATCH v4 6/6] iio: common: scmi_iio: convert to dev_err_probe() Nuno Sa via B4 Relay
2024-03-28 16:56 ` [PATCH v4 0/6] iio: temperature: ltc2983: small improvements Jonathan Cameron
2024-03-28 17:07 ` Nuno Sá [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0f985b272af85aea912479ced50ff52f29506b1.camel@gmail.com \
--to=noname.nuno@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=devnull+nuno.sa.analog.com@kernel.org \
--cc=jbhayana@google.com \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=olivier.moysan@foss.st.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).