From: Javier Carrasco <javier.carrasco.cruz@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Matt Ranostay <matt@ranostay.sg>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: iio: health: maxim,max30102: add max30101
Date: Sun, 24 Mar 2024 20:05:42 +0100 [thread overview]
Message-ID: <d4bebe80-ade4-4b91-91e8-6d67fe4b69cd@gmail.com> (raw)
In-Reply-To: <20240324134615.0380ef81@jic23-huawei>
On 3/24/24 14:46, Jonathan Cameron wrote:
> On Thu, 21 Mar 2024 19:33:48 +0100
> Javier Carrasco <javier.carrasco.cruz@gmail.com> wrote:
>
>> The Maxim max30101 irs the replacement for the max30105, which is no
>> longer recommended for future designs.
>>
>> The max30101 does not require new properties, and it can be described
>> with the existing ones for the max30105.
>>
>> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
>
> Given there were no driver changes, is it fully compatible?
> i.e. Should we have a fallback compatible here?
>
> properties:
> compatible:
> oneOf:
> - items:
> - const: maxim,max30101
> - const: maxim,max30105
> - enum:
> - maxim,max30102
> - maxim,max30105
>
> So that a DTS file could use
> compatible = "maxim,max30101", "maxim,max30105"
> and work with older kernels as well as new ones that understand the new ID?
>
According to the manufacturer, it is fully compatible, and apart from
the pinout, I could not find any difference beyond the device description.
I like the idea of having a fallback compatible for older kernels, so I
will add it to v2 as you suggested.
Thanks and best regards,
Javier Carrasco
next prev parent reply other threads:[~2024-03-24 19:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-21 18:33 [PATCH 0/2] iio: health: max30102: add support for max30101 Javier Carrasco
2024-03-21 18:33 ` [PATCH 1/2] dt-bindings: iio: health: maxim,max30102: add max30101 Javier Carrasco
2024-03-22 2:09 ` Rob Herring
2024-03-24 13:41 ` Jonathan Cameron
2024-03-24 13:46 ` Jonathan Cameron
2024-03-24 19:05 ` Javier Carrasco [this message]
2024-03-21 18:33 ` [PATCH 2/2] iio: health: max30102: add support for max30101 Javier Carrasco
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d4bebe80-ade4-4b91-91e8-6d67fe4b69cd@gmail.com \
--to=javier.carrasco.cruz@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@ranostay.sg \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).