From: Andy Shevchenko <andy@kernel.org>
To: Alisa-Dariana Roman <alisadariana@gmail.com>
Cc: michael.hennerich@analog.com, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
lars@metafoo.de, jic23@kernel.org, robh@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
lgirdwood@gmail.com, broonie@kernel.org, nuno.sa@analog.com,
marcelo.schmitt@analog.com, bigunclemax@gmail.com,
dlechner@baylibre.com, okan.sahin@analog.com,
fr0st61te@gmail.com, alisa.roman@analog.com,
marcus.folkesson@gmail.com, schnelle@linux.ibm.com,
liambeguin@gmail.com
Subject: Re: [PATCH v8 3/6] iio: adc: ad7192: Add aincom supply
Date: Tue, 14 May 2024 16:13:05 +0300 [thread overview]
Message-ID: <ZkNjYZew7Mko7iPX@smile.fi.intel.com> (raw)
In-Reply-To: <20240514120222.56488-4-alisa.roman@analog.com>
On Tue, May 14, 2024 at 03:02:19PM +0300, Alisa-Dariana Roman wrote:
> AINCOM should actually be a supply. AINx inputs are referenced to AINCOM
> in pseudo-differential operation mode. AINCOM voltage represents the
> offset of corresponding channels.
...
Possible cleanup with the help of
struct device *dev = &spi->dev;
> struct ad7192_state *st;
> struct iio_dev *indio_dev;
> + struct regulator *aincom;
> int ret;
...
> + aincom = devm_regulator_get_optional(&spi->dev, "aincom");
aincom = devm_regulator_get_optional(dev, "aincom");
...
> + return dev_err_probe(&spi->dev, PTR_ERR(aincom),
> + "Failed to get AINCOM supply\n");
return dev_err_probe(dev, PTR_ERR(aincom),
"Failed to get AINCOM supply\n");
...
> + return dev_err_probe(&spi->dev, ret,
> + "Failed to enable specified AINCOM supply\n");
return dev_err_probe(dev, ret,
"Failed to enable specified AINCOM supply\n");
...
> + ret = devm_add_action_or_reset(&spi->dev, ad7192_reg_disable, aincom);
ret = devm_add_action_or_reset(dev, ad7192_reg_disable, aincom);
...
> + return dev_err_probe(&spi->dev, ret,
> + "Device tree error, AINCOM voltage undefined\n");
return dev_err_probe(dev, ret,
"Device tree error, AINCOM voltage undefined\n");
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-05-14 13:13 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-14 12:02 [PATCH v8 0/6] iio: adc: ad7192: Add AD7194 support Alisa-Dariana Roman
2024-05-14 12:02 ` [PATCH v8 1/6] iio: adc: ad7192: Use standard attribute Alisa-Dariana Roman
2024-05-19 17:45 ` Jonathan Cameron
2024-05-14 12:02 ` [PATCH v8 2/6] dt-bindings: iio: adc: ad7192: Add aincom supply Alisa-Dariana Roman
2024-05-19 17:54 ` Jonathan Cameron
2024-05-14 12:02 ` [PATCH v8 3/6] " Alisa-Dariana Roman
2024-05-14 13:13 ` Andy Shevchenko [this message]
2024-05-19 17:53 ` Jonathan Cameron
2024-05-14 12:02 ` [PATCH v8 4/6] dt-bindings: iio: adc: Add single-channel property Alisa-Dariana Roman
2024-05-14 18:57 ` Conor Dooley
2024-05-14 12:02 ` [PATCH v8 5/6] dt-bindings: iio: adc: ad7192: Add AD7194 support Alisa-Dariana Roman
2024-05-14 18:58 ` Conor Dooley
2024-05-14 12:02 ` [PATCH v8 6/6] " Alisa-Dariana Roman
2024-05-14 13:09 ` Andy Shevchenko
2024-05-19 18:03 ` Jonathan Cameron
2024-05-19 19:37 ` Alisa-Dariana Roman
2024-05-20 12:20 ` Jonathan Cameron
2024-05-20 12:28 ` Andy Shevchenko
2024-05-22 9:50 ` [PATCH] fix Alisa-Dariana Roman
2024-05-25 16:35 ` Jonathan Cameron
2024-05-14 13:14 ` [PATCH v8 0/6] iio: adc: ad7192: Add AD7194 support Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZkNjYZew7Mko7iPX@smile.fi.intel.com \
--to=andy@kernel.org \
--cc=alisa.roman@analog.com \
--cc=alisadariana@gmail.com \
--cc=bigunclemax@gmail.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=fr0st61te@gmail.com \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=liambeguin@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.schmitt@analog.com \
--cc=marcus.folkesson@gmail.com \
--cc=michael.hennerich@analog.com \
--cc=nuno.sa@analog.com \
--cc=okan.sahin@analog.com \
--cc=robh@kernel.org \
--cc=schnelle@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).