From: Dominique Martinet <dominique.martinet@atmark-techno.com>
To: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
"Syunya Ohshio" <syunya.ohshio@atmark-techno.com>,
"Guido Günther" <agx@sigxcpu.org>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: industrialio-core: look for aliases to request device index
Date: Thu, 11 Apr 2024 14:11:08 +0900 [thread overview]
Message-ID: <Zhdw7GPdOe2nOhJy@atmark-techno.com> (raw)
In-Reply-To: <20240401174756.0000786a@Huawei.com>
Jonathan Cameron wrote on Mon, Apr 01, 2024 at 05:47:56PM +0100:
> Good luck. If you have time it might be good to hear what you end up
> with!
Just a quick follow-up since you asked -- given we manage our own kernel
that already has its share of patches and it's not something
user-visible we'll stick with the aliases approach for this kernel to
make identifiers static.
(and I'm adding labels for meticulous users, but not expecting it to be
used in practice, it'll mostly be used in automated testing to make sure
the number doesn't change on our end)
The rationale was as per my previous mails that paths in
/sys/devices/platform have changed in the past so we'd rather not rely
on these being set in stone, and while a new symlink would have been
workable it's a user-noticeable change so we've prefered just pinning
the device numbers.
I'm always reluctant to take in more "in house" patches in our tree but
in this case it's "simple enough" (death by thousands paper cut?), and
we'll rediscuss this if/when another upstream solution shows up.
Thanks a lot for your time thinking it through and discussing it though,
that was appreciated!
(Jonathan and everyone else involved)
--
Dominique
next prev parent reply other threads:[~2024-04-11 5:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-28 5:12 [PATCH] iio: industrialio-core: look for aliases to request device index Dominique Martinet
2024-02-28 7:16 ` Krzysztof Kozlowski
2024-02-28 7:31 ` Dominique Martinet
2024-02-28 7:42 ` Krzysztof Kozlowski
2024-02-28 8:11 ` Dominique Martinet
2024-02-28 14:24 ` Jonathan Cameron
2024-02-29 2:59 ` Dominique Martinet
2024-03-15 5:47 ` Dominique Martinet
2024-03-15 15:53 ` David Lechner
2024-03-16 20:17 ` Andy Shevchenko
2024-03-18 2:15 ` Dominique Martinet
2024-03-18 12:29 ` Jonathan Cameron
2024-03-31 14:20 ` Jonathan Cameron
2024-04-01 8:18 ` Dominique Martinet
2024-04-01 16:47 ` Jonathan Cameron
2024-04-11 5:11 ` Dominique Martinet [this message]
2024-03-18 14:55 ` David Lechner
2024-03-16 20:14 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zhdw7GPdOe2nOhJy@atmark-techno.com \
--to=dominique.martinet@atmark-techno.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=agx@sigxcpu.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=syunya.ohshio@atmark-techno.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).