From: Gerald Loacker <gerald.loacker@wolfvision.net>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-iio@vger.kernel.org
Subject: Re: [PATCH] iio: tmag5273: Remove some unused field in struct tmag5273_data
Date: Thu, 2 May 2024 10:01:20 +0200 [thread overview]
Message-ID: <785c080e-c133-40f1-9b15-2854827a0a0d@wolfvision.net> (raw)
In-Reply-To: <7bd16d7fea12c64b6b3dc3cd32839cfce145bcf3.1714562912.git.christophe.jaillet@wanadoo.fr>
Hi Christophe,
Am 01.05.2024 um 13:28 schrieb Christophe JAILLET:
> In "struct tmag5273_data", the 'scale' and 'vcc' fields are unused.
> Remove them.
>
> Found with cppcheck, unusedStructMember.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> Compile tested only.
>
> It was added in the initial commit 866a1389174b ("iio: magnetometer: add
> ti tmag5273 driver") but was never used.
> ---
> drivers/iio/magnetometer/tmag5273.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/iio/magnetometer/tmag5273.c b/drivers/iio/magnetometer/tmag5273.c
> index 218b1ce076c1..4187abe12784 100644
> --- a/drivers/iio/magnetometer/tmag5273.c
> +++ b/drivers/iio/magnetometer/tmag5273.c
> @@ -118,11 +118,9 @@ struct tmag5273_data {
> unsigned int version;
> char name[16];
> unsigned int conv_avg;
> - unsigned int scale;
> enum tmag5273_scale_index scale_index;
> unsigned int angle_measurement;
> struct regmap *map;
> - struct regulator *vcc;
>
> /*
> * Locks the sensor for exclusive use during a measurement (which
Thanks for cleaning up.
Reviewed-by: Gerald Loacker <gerald.loacker@wolfvision.net>
Regards,
Gerald
prev parent reply other threads:[~2024-05-02 8:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-01 11:28 [PATCH] iio: tmag5273: Remove some unused field in struct tmag5273_data Christophe JAILLET
2024-05-02 8:01 ` Gerald Loacker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=785c080e-c133-40f1-9b15-2854827a0a0d@wolfvision.net \
--to=gerald.loacker@wolfvision.net \
--cc=christophe.jaillet@wanadoo.fr \
--cc=jic23@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).