From: marc.ferland@gmail.com
To: lars@metafoo.de
Cc: Michael.Hennerich@analog.com, jic23@kernel.org,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
Marc Ferland <marc.ferland@sonatest.com>
Subject: [PATCH] iio: dac: ad5592r: fix temperature scale
Date: Tue, 30 Apr 2024 09:13:30 -0400 [thread overview]
Message-ID: <20240430131330.1555849-1-marc.ferland@sonatest.com> (raw)
From: Marc Ferland <marc.ferland@sonatest.com>
For temperature readings, the remainder is returned as nano Celsius
_but_ we mark it as IIO_VAL_INT_PLUS_MICRO. This results in incorrect
temperature reporting through hwmon for example. I have a board here
which reports the following when running 'sensors':
iio_hwmon-isa-0000
Adapter: ISA adapter
temp1: +93.3°C
With the patch applied, it returns the correct temperature:
iio_hwmon-isa-0000
Adapter: ISA adapter
temp1: +30.5°C
Signed-off-by: Marc Ferland <marc.ferland@sonatest.com>
---
drivers/iio/dac/ad5592r-base.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/dac/ad5592r-base.c b/drivers/iio/dac/ad5592r-base.c
index 076bc9ecfb49..4763402dbcd6 100644
--- a/drivers/iio/dac/ad5592r-base.c
+++ b/drivers/iio/dac/ad5592r-base.c
@@ -415,7 +415,7 @@ static int ad5592r_read_raw(struct iio_dev *iio_dev,
s64 tmp = *val * (3767897513LL / 25LL);
*val = div_s64_rem(tmp, 1000000000LL, val2);
- return IIO_VAL_INT_PLUS_MICRO;
+ return IIO_VAL_INT_PLUS_NANO;
}
mutex_lock(&st->lock);
base-commit: 98369dccd2f8e16bf4c6621053af7aa4821dcf8e
--
2.34.1
next reply other threads:[~2024-04-30 13:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-30 13:13 marc.ferland [this message]
2024-04-30 13:59 ` [PATCH] iio: dac: ad5592r: fix temperature scale Jonathan Cameron
2024-04-30 14:26 ` Marc Ferland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240430131330.1555849-1-marc.ferland@sonatest.com \
--to=marc.ferland@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.ferland@sonatest.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).