From: Jonathan Cameron <jic23@kernel.org>
To: "Nuno Sá" <noname.nuno@gmail.com>
Cc: ogustavo@usp.br, lars@metafoo.de, Michael.Hennerich@analog.com,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] iio: adc: ad799x: Fix warning generated by checkpatch
Date: Mon, 29 Apr 2024 20:58:31 +0100 [thread overview]
Message-ID: <20240429205831.662da28a@jic23-huawei> (raw)
In-Reply-To: <3f8880a7c7bf6be0458ce2ec2deedeb505c4427f.camel@gmail.com>
On Mon, 29 Apr 2024 09:28:25 +0200
Nuno Sá <noname.nuno@gmail.com> wrote:
> On Sun, 2024-04-28 at 16:43 -0300, ogustavo@usp.br wrote:
> > From: Gustavo Rodrigues <ogustavo@usp.br>
> >
> > Clean code of iio:adc:ad799x to cease warning messages pointed by
> > checkpatch. These include proper variable declaration 'unsigned' to
> > 'unsigned int', add blank line and use of octal permission instead of
> > symbolic.
> >
> > Gustavo (3):
> > iio: adc: ad799x: change 'unsigned' to 'unsigned int' declaration
> > iio: adc: ad799x.c: add blank line to avoid warning messages
> > iio: adc: ad799x: Prefer to use octal permission instead of symbolic
> >
> > drivers/iio/adc/ad799x.c | 7 ++++---
> > 1 file changed, 4 insertions(+), 3 deletions(-)
> >
>
> Patches look good. Just one note... It seems Marcelo gave some feedback on a
> previous iterations so it looks like this should have been marked as v2?
>
> Anyways,
>
> Reviewed-by: Nuno Sa <nuno.sa@analog.com>
>
Indeed on v2. Anyhow, applied to the togreg branch of iio.git and pushed
out as testing for the autobuilders to see if we missed anything,
Thanks,
Jonathan
next prev parent reply other threads:[~2024-04-29 19:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-28 19:43 [PATCH 0/3] iio: adc: ad799x: Fix warning generated by checkpatch ogustavo
2024-04-28 19:43 ` [PATCH 1/3] iio: adc: ad799x: change 'unsigned' to 'unsigned int' declaration ogustavo
2024-04-28 19:43 ` [PATCH 2/3] iio: adc: ad799x: add blank line to avoid warning messages ogustavo
2024-04-28 19:43 ` [PATCH 3/3] iio: adc: ad799x: Prefer to use octal permission ogustavo
2024-04-29 7:28 ` [PATCH 0/3] iio: adc: ad799x: Fix warning generated by checkpatch Nuno Sá
2024-04-29 19:58 ` Jonathan Cameron [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-04-26 1:23 Gustavo
2024-04-27 10:39 ` Marcelo Schmitt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240429205831.662da28a@jic23-huawei \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=noname.nuno@gmail.com \
--cc=ogustavo@usp.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).