From: Jonathan Cameron <jic23@kernel.org>
To: "Nuno Sá" <noname.nuno@gmail.com>
Cc: Ramona Gradinariu <ramona.bolboaca13@gmail.com>,
linux-kernel@vger.kernel.org, nuno.sa@analog.com,
linux-iio@vger.kernel.org
Subject: Re: [PATCH v2 1/1] iio:imu: adis16475: Fix sync mode setting
Date: Sat, 6 Apr 2024 16:46:33 +0100 [thread overview]
Message-ID: <20240406164633.76e3601b@jic23-huawei> (raw)
In-Reply-To: <00ed6785db2b43ec3727f42c71dc2c8dd1b627f1.camel@gmail.com>
On Fri, 05 Apr 2024 09:02:33 +0200
Nuno Sá <noname.nuno@gmail.com> wrote:
> On Fri, 2024-04-05 at 07:53 +0300, Ramona Gradinariu wrote:
> > Fix sync mode setting by applying the necessary shift bits.
> >
> > Fixes: fff7352bf7a3 ("iio: imu: Add support for adis16475")
> > Signed-off-by: Ramona Gradinariu <ramona.bolboaca13@gmail.com>
> > ---
>
> Not sure there was a reason to drop my tag... Anyways:
>
> Reviewed-by: Nuno Sa <nuno.sa@analog.com>
Missing -S on b4 maybe? A special parameter I save just for you Nuno ;)
Applied to the fixes-togreg branch of iio.git and marked for stable.
Thanks,
Jonathan
>
> > changes in v2:
> > - added u16 value to call __adis_update_bits to fix build error
> > drivers/iio/imu/adis16475.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/iio/imu/adis16475.c b/drivers/iio/imu/adis16475.c
> > index 01f55cc902fa..060a21c70460 100644
> > --- a/drivers/iio/imu/adis16475.c
> > +++ b/drivers/iio/imu/adis16475.c
> > @@ -1289,6 +1289,7 @@ static int adis16475_config_sync_mode(struct adis16475
> > *st)
> > struct device *dev = &st->adis.spi->dev;
> > const struct adis16475_sync *sync;
> > u32 sync_mode;
> > + u16 val;
> >
> > /* default to internal clk */
> > st->clk_freq = st->info->int_clk * 1000;
> > @@ -1350,8 +1351,9 @@ static int adis16475_config_sync_mode(struct adis16475
> > *st)
> > * I'm keeping this for simplicity and avoiding extra variables
> > * in chip_info.
> > */
> > + val = ADIS16475_SYNC_MODE(sync->sync_mode);
> > ret = __adis_update_bits(&st->adis, ADIS16475_REG_MSG_CTRL,
> > - ADIS16475_SYNC_MODE_MASK, sync->sync_mode);
> > + ADIS16475_SYNC_MODE_MASK, val);
> > if (ret)
> > return ret;
> >
> > --
> > 2.34.1
> >
>
prev parent reply other threads:[~2024-04-06 15:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-05 4:53 [PATCH v2 0/1] iio:imu: adis16475: Fix sync mode setting Ramona Gradinariu
2024-04-05 4:53 ` [PATCH v2 1/1] " Ramona Gradinariu
2024-04-05 7:02 ` Nuno Sá
2024-04-06 15:46 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240406164633.76e3601b@jic23-huawei \
--to=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=noname.nuno@gmail.com \
--cc=nuno.sa@analog.com \
--cc=ramona.bolboaca13@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).