From: Conor Dooley <conor@kernel.org>
To: inv.git-commit@tdk.com
Cc: jic23@kernel.org, robh@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
lars@metafoo.de, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org,
Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com>
Subject: Re: [PATCH 2/2] dt-bindings: iio: imu: add icm42688 inside inv_icm42600
Date: Fri, 29 Mar 2024 15:49:26 +0000 [thread overview]
Message-ID: <20240329-fifth-earpiece-78daf4d943ce@spud> (raw)
In-Reply-To: <20240329151535.712827-3-inv.git-commit@tdk.com>
[-- Attachment #1: Type: text/plain, Size: 1232 bytes --]
On Fri, Mar 29, 2024 at 03:15:35PM +0000, inv.git-commit@tdk.com wrote:
> From: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com>
>
> Add bindings for ICM-42688-P chip.
>
> Signed-off-by: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com>
My initial thought was that you're missing a sign-off, but is
"inv.git-commit@tdk.com" some system you have to bypass corporate email
garbage?
> ---
> .../devicetree/bindings/iio/imu/invensense,icm42600.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml b/Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml
> index 7cd05bcbee31..152aec8d82ff 100644
> --- a/Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml
> +++ b/Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml
> @@ -31,6 +31,7 @@ properties:
> - invensense,icm42602
> - invensense,icm42605
> - invensense,icm42622
> + - invensense,icm42688
Can you add this in alphanumerical order please?
Also, this patch should be the first in the series.
Thanks,
Conor.
> - invensense,icm42631
>
> reg:
> --
> 2.34.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2024-03-29 15:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-29 15:15 [PATCH 0/2] iio: imu: inv_icm42600: add support of ICM-42688-P inv.git-commit
2024-03-29 15:15 ` [PATCH 1/2] " inv.git-commit
2024-03-29 15:15 ` [PATCH 2/2] dt-bindings: iio: imu: add icm42688 inside inv_icm42600 inv.git-commit
2024-03-29 15:49 ` Conor Dooley [this message]
2024-03-30 16:10 ` Jonathan Cameron
2024-04-01 11:04 ` Conor Dooley
2024-04-01 16:57 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240329-fifth-earpiece-78daf4d943ce@spud \
--to=conor@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=inv.git-commit@tdk.com \
--cc=jean-baptiste.maneyrol@tdk.com \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).