From: Colin Ian King <colin.i.king@gmail.com>
To: Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Cosmin Tanislav <cosmin.tanislav@analog.com>,
Jonathan Cameron <jic23@kernel.org>,
linux-iio@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH][next] iio: addac: ad74115: remove redundant if statement
Date: Thu, 28 Mar 2024 11:22:11 +0000 [thread overview]
Message-ID: <20240328112211.761618-1-colin.i.king@gmail.com> (raw)
The if statement is redundant because the variable i being
assigned in the statement is never read afterwards. Remove it.
Cleans up clang scan build warning:
drivers/iio/addac/ad74115.c:570:3: warning: Value stored to 'i'
is never read [deadcode.DeadStores]
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
drivers/iio/addac/ad74115.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/iio/addac/ad74115.c b/drivers/iio/addac/ad74115.c
index e6bc5eb3788d..d31d4adb017e 100644
--- a/drivers/iio/addac/ad74115.c
+++ b/drivers/iio/addac/ad74115.c
@@ -566,9 +566,6 @@ static int ad74115_set_comp_debounce(struct ad74115_state *st, unsigned int val)
if (val <= ad74115_debounce_tbl[i])
break;
- if (i == len)
- i = len - 1;
-
return regmap_update_bits(st->regmap, AD74115_DIN_CONFIG1_REG,
AD74115_DIN_DEBOUNCE_MASK,
FIELD_PREP(AD74115_DIN_DEBOUNCE_MASK, val));
--
2.39.2
next reply other threads:[~2024-03-28 11:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-28 11:22 Colin Ian King [this message]
2024-03-28 13:52 ` [PATCH][next] iio: addac: ad74115: remove redundant if statement Nuno Sá
2024-03-28 14:14 ` Dan Carpenter
2024-03-28 15:56 ` Nuno Sá
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240328112211.761618-1-colin.i.king@gmail.com \
--to=colin.i.king@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=cosmin.tanislav@analog.com \
--cc=jic23@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).