From: Jonathan Cameron <jic23@kernel.org>
To: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
<devicetree@vger.kernel.org>, <imx@lists.linux.dev>,
<linux-arm-kernel@lists.infradead.org>,
"Trevor Zaharichuk" <trevor@au-zone.com>,
Greg Lytle <greg@au-zone.com>,
"Lars-Peter Clausen" <lars@metafoo.de>,
Rob Herring <robh@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Sean Nyekjaer <sean@geanix.com>, <linux-iio@vger.kernel.org>
Subject: Re: [PATCH 1/5] dt-bindings: iio: dac: ti,dac5571: Add DAC081C081 support
Date: Tue, 26 Mar 2024 18:21:52 +0000 [thread overview]
Message-ID: <20240326182152.03f860e5@jic23-huawei> (raw)
In-Reply-To: <20240326171316.000018f5@Huawei.com>
On Tue, 26 Mar 2024 17:13:16 +0000
Jonathan Cameron <Jonathan.Cameron@Huawei.com> wrote:
> On Tue, 26 Mar 2024 18:50:43 +0200
> Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote:
>
> > On Tue, Mar 26, 2024 at 03:29:27PM +0000, Jonathan Cameron wrote:
> > > On Mon, 25 Mar 2024 22:56:41 +0200 Laurent Pinchart wrote:
> > > > On Mon, Mar 25, 2024 at 08:48:57PM +0000, Jonathan Cameron wrote:
> > > > > On Mon, 25 Mar 2024 22:32:41 +0200 Laurent Pinchart wrote:
> > > > >
> > > > > > The DAC081C081 is a TI DAC whose software interface is compatible with
> > > > > > the DAC5571. It is the 8-bit version of the DAC121C081, already
> > > > > > supported by the DAC5571 bindings. Extends the bindings to support this
> > > > > > chip.
> > > > > >
> > > > > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > > > >
> > > > > Hi Laurent,
> > > > >
> > > > > Given it's a part number where no one is going to guess it is compatible
> > > > > with the DAC5571 and that we don't have a history of fallback compatibles
> > > > > I'm fine with this change, but just wanted to ask is a fallback compatible
> > > > > useful to you to run with older kernels?
> > > > >
> > > > > I should have noticed when Peter added the dac121c081. If we add a fallback
> > > > > should do that one as well.
> > > >
> > > > I've indeed noticed that there should have been a fallback for
> > > > dac121c081, but didn't stop to ponder why that wasn't the case, and just
> > > > went along with the flow :-) I agree a fallback could be useful, which
> > > > would then allow dropping patch 2/5 from this series (*). I can do so if
> > > > you prefer.
> > > >
> > > > * This is not entirely true. While the DAC1081C081 is largely compatible
> > > > with the DAC5573, they have different values for one of the power-down
> > > > resistors (2.5kΩ instead of 1kΩ if I recall correctly). To be completely
> > > > accurate, the driver should report that. We could still use the fallback
> > > > compatible, reporting the wrong power-down resistor value.
> > >
> > > Hmm - Would anyone really care about that value being wrong?
> >
> > I don't have enough expertise with IIO to be sure, but my guess is that
> > nobody would.
> >
> > > I think perhaps that's just about significant enough that maybe a fallback
> > > compatible doesn't make sense here.
> >
> > Then let's keep it simple and just merge this patch as-is ? :-)
> Makes sense. I'm on wrong computer at the moment but will pick it up at
> weekend if not before.
Sooner it is. Applied 1 and 2 to the togreg branch of iio.git and pushed
out as testing on the extremely unlikely chance that 0-day finds a build
issue...
I grabbed them today because I have a memory like a gold fish and the thread
is deep enough that I might skip over later on basis 'it must have outstanding
questions' :)
Jonathan
>
> Jonathan
>
>
> >
> > > > > > ---
> > > > > > Documentation/devicetree/bindings/iio/dac/ti,dac5571.yaml | 1 +
> > > > > > 1 file changed, 1 insertion(+)
> > > > > >
> > > > > > diff --git a/Documentation/devicetree/bindings/iio/dac/ti,dac5571.yaml b/Documentation/devicetree/bindings/iio/dac/ti,dac5571.yaml
> > > > > > index 79da0323c327..e59db861e2eb 100644
> > > > > > --- a/Documentation/devicetree/bindings/iio/dac/ti,dac5571.yaml
> > > > > > +++ b/Documentation/devicetree/bindings/iio/dac/ti,dac5571.yaml
> > > > > > @@ -21,6 +21,7 @@ properties:
> > > > > > - ti,dac5573
> > > > > > - ti,dac6573
> > > > > > - ti,dac7573
> > > > > > + - ti,dac081c081
> > > > > > - ti,dac121c081
> > > > > >
> > > > > > reg:
> >
>
next prev parent reply other threads:[~2024-03-26 18:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-25 20:32 [PATCH 0/5] arm64: dts: Add device tree source for the Au-Zone Maivin AI Vision Starter Kit Laurent Pinchart
2024-03-25 20:32 ` [PATCH 1/5] dt-bindings: iio: dac: ti,dac5571: Add DAC081C081 support Laurent Pinchart
2024-03-25 20:48 ` Jonathan Cameron
2024-03-25 20:56 ` Laurent Pinchart
2024-03-25 22:23 ` Laurent Pinchart
2024-03-25 22:32 ` Jonathan Cameron
2024-03-26 15:29 ` Jonathan Cameron
2024-03-26 16:50 ` Laurent Pinchart
2024-03-26 17:13 ` Jonathan Cameron
2024-03-26 18:21 ` Jonathan Cameron [this message]
2024-03-26 9:00 ` Sean Nyekjaer
2024-03-25 20:32 ` [PATCH 2/5] iio: dac: ti-dac5571: " Laurent Pinchart
2024-03-26 9:00 ` Sean Nyekjaer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240326182152.03f860e5@jic23-huawei \
--to=jic23@kernel.org \
--cc=Jonathan.Cameron@Huawei.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=greg@au-zone.com \
--cc=imx@lists.linux.dev \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sean@geanix.com \
--cc=trevor@au-zone.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).