From: Jonathan Cameron <jic23@kernel.org>
To: Vasileios Amoiridis <vassilisamir@gmail.com>
Cc: lars@metafoo.de, andriy.shevchenko@linux.intel.com,
ang.iglesiasg@gmail.com, phil@raspberrypi.com, 579lpy@gmail.com,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: pressure: Fixes SPI support for BMP3xx devices
Date: Thu, 14 Mar 2024 14:27:00 +0000 [thread overview]
Message-ID: <20240314142700.32df91a2@jic23-huawei> (raw)
In-Reply-To: <20240311005432.1752853-1-vassilisamir@gmail.com>
On Mon, 11 Mar 2024 01:54:32 +0100
Vasileios Amoiridis <vassilisamir@gmail.com> wrote:
> Bosch does not use unique BMPxxx_CHIP_ID for the different versions of
> the device which leads to misidentification of devices if their ID is
> used. Use a new value in the chip_info structure instead of the
> BMPxxx_CHIP_ID, in order to choose the regmap_bus to be used.
>
> Fixes: a9dd9ba32311 ("iio: pressure: Fixes BMP38x and BMP390 SPI support")
> Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com>
Other than switching to a bool as Andy suggested, this looks fine to me.
Jonathan
> ---
> drivers/iio/pressure/bmp280-core.c | 1 +
> drivers/iio/pressure/bmp280-spi.c | 9 ++-------
> drivers/iio/pressure/bmp280.h | 1 +
> 3 files changed, 4 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/iio/pressure/bmp280-core.c b/drivers/iio/pressure/bmp280-core.c
> index fe8734468ed3..5ea9039caf75 100644
> --- a/drivers/iio/pressure/bmp280-core.c
> +++ b/drivers/iio/pressure/bmp280-core.c
> @@ -1233,6 +1233,7 @@ const struct bmp280_chip_info bmp380_chip_info = {
> .chip_id = bmp380_chip_ids,
> .num_chip_id = ARRAY_SIZE(bmp380_chip_ids),
> .regmap_config = &bmp380_regmap_config,
> + .spi_read_extra_byte = 1,
> .start_up_time = 2000,
> .channels = bmp380_channels,
> .num_channels = 2,
> diff --git a/drivers/iio/pressure/bmp280-spi.c b/drivers/iio/pressure/bmp280-spi.c
> index a444d4b2978b..3a5fec5d47fd 100644
> --- a/drivers/iio/pressure/bmp280-spi.c
> +++ b/drivers/iio/pressure/bmp280-spi.c
> @@ -96,15 +96,10 @@ static int bmp280_spi_probe(struct spi_device *spi)
>
> chip_info = spi_get_device_match_data(spi);
>
> - switch (chip_info->chip_id[0]) {
> - case BMP380_CHIP_ID:
> - case BMP390_CHIP_ID:
> + if (chip_info->spi_read_extra_byte)
> bmp_regmap_bus = &bmp380_regmap_bus;
> - break;
> - default:
> + else
> bmp_regmap_bus = &bmp280_regmap_bus;
> - break;
> - }
>
> regmap = devm_regmap_init(&spi->dev,
> bmp_regmap_bus,
> diff --git a/drivers/iio/pressure/bmp280.h b/drivers/iio/pressure/bmp280.h
> index 4012387d7956..70bceaccf447 100644
> --- a/drivers/iio/pressure/bmp280.h
> +++ b/drivers/iio/pressure/bmp280.h
> @@ -423,6 +423,7 @@ struct bmp280_chip_info {
> int num_chip_id;
>
> const struct regmap_config *regmap_config;
> + int spi_read_extra_byte;
>
> const struct iio_chan_spec *channels;
> int num_channels;
prev parent reply other threads:[~2024-03-14 14:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-11 0:54 [PATCH] iio: pressure: Fixes SPI support for BMP3xx devices Vasileios Amoiridis
2024-03-11 10:05 ` Andy Shevchenko
2024-03-11 15:58 ` Jonathan Cameron
2024-03-11 16:44 ` Vasileios Amoiridis
2024-03-14 14:27 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240314142700.32df91a2@jic23-huawei \
--to=jic23@kernel.org \
--cc=579lpy@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=ang.iglesiasg@gmail.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phil@raspberrypi.com \
--cc=vassilisamir@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).