From: Damien Le Moal <dlemoal@kernel.org>
To: Ondrej Zary <linux@zary.sk>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Christoph Hellwig <hch@lst.de>,
Sergey Shtylyov <s.shtylyov@omp.ru>, Tim Waugh <tim@cyberelk.net>,
linux-parport@lists.infradead.org, linux-ide@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] ata: pata_parport: implement set_devctl
Date: Thu, 5 Oct 2023 07:44:30 +0900 [thread overview]
Message-ID: <583d9807-764b-9266-bf55-e6aefe8c4b82@kernel.org> (raw)
In-Reply-To: <20231004185235.27417-3-linux@zary.sk>
On 10/5/23 03:52, Ondrej Zary wrote:
> Add missing ops->sff_set_devctl implementation.
>
> Fixes: 246a1c4c6b7f ("ata: pata_parport: add driver (PARIDE replacement)")
Missing "Cc: stable@vger.kernel.org" here. Same comment for patch 1.
Otherwise, looks OK.
> Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
> Signed-off-by: Ondrej Zary <linux@zary.sk>
> ---
> drivers/ata/pata_parport/pata_parport.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/ata/pata_parport/pata_parport.c b/drivers/ata/pata_parport/pata_parport.c
> index 258d189f42e5..cf87bbb52f1f 100644
> --- a/drivers/ata/pata_parport/pata_parport.c
> +++ b/drivers/ata/pata_parport/pata_parport.c
> @@ -51,6 +51,13 @@ static void pata_parport_dev_select(struct ata_port *ap, unsigned int device)
> ata_sff_pause(ap);
> }
>
> +static void pata_parport_set_devctl(struct ata_port *ap, u8 ctl)
> +{
> + struct pi_adapter *pi = ap->host->private_data;
> +
> + pi->proto->write_regr(pi, 1, 6, ctl);
> +}
> +
> static bool pata_parport_devchk(struct ata_port *ap, unsigned int device)
> {
> struct pi_adapter *pi = ap->host->private_data;
> @@ -252,6 +259,7 @@ static struct ata_port_operations pata_parport_port_ops = {
> .hardreset = NULL,
>
> .sff_dev_select = pata_parport_dev_select,
> + .sff_set_devctl = pata_parport_set_devctl,
> .sff_check_status = pata_parport_check_status,
> .sff_check_altstatus = pata_parport_check_altstatus,
> .sff_tf_load = pata_parport_tf_load,
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2023-10-04 22:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-04 18:52 [PATCH v2 0/4] ata: pata_parport: fix EXP Computer CD-865 with MC-1285B EPP cable Ondrej Zary
2023-10-04 18:52 ` [PATCH 1/4] ata: pata_parport: fix pata_parport_devchk Ondrej Zary
2023-10-04 18:52 ` [PATCH 2/4] ata: pata_parport: implement set_devctl Ondrej Zary
2023-10-04 22:44 ` Damien Le Moal [this message]
2023-10-04 18:52 ` [PATCH 3/4] ata: pata_parport: add custom version of wait_after_reset Ondrej Zary
2023-10-04 18:52 ` [PATCH 4/4] ata: pata_parport: fit3: implement IDE command set registers Ondrej Zary
2023-10-04 22:43 ` Damien Le Moal
-- strict thread matches above, loose matches on Subject: below --
2023-10-05 19:24 [PATCH v3 0/4] ata: pata_parport: fix EXP Computer CD-865 with MC-1285B EPP cable Ondrej Zary
2023-10-05 19:24 ` [PATCH 2/4] ata: pata_parport: implement set_devctl Ondrej Zary
2023-10-05 20:55 [PATCH v4 0/4] ata: pata_parport: fix EXP Computer CD-865 with MC-1285B EPP cable Ondrej Zary
2023-10-05 20:55 ` [PATCH 2/4] ata: pata_parport: implement set_devctl Ondrej Zary
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=583d9807-764b-9266-bf55-e6aefe8c4b82@kernel.org \
--to=dlemoal@kernel.org \
--cc=hch@lst.de \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parport@lists.infradead.org \
--cc=linux@zary.sk \
--cc=s.shtylyov@omp.ru \
--cc=sudipm.mukherjee@gmail.com \
--cc=tim@cyberelk.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).