From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Animesh Agarwal <animeshagarwal28@gmail.com>
Cc: Damien Le Moal <dlemoal@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
linux-ide@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] dt-bindings: imx-pata: Convert to dtschema
Date: Sun, 10 Mar 2024 09:11:57 +0100 [thread overview]
Message-ID: <5572ba82-25ce-4216-a1e9-3a7def42cb28@linaro.org> (raw)
In-Reply-To: <CAE3Oz80eZffUp9NCdkGYzt-uin8aevVx6w9Zxye6R1CURQjrhA@mail.gmail.com>
On 10/03/2024 09:03, Animesh Agarwal wrote:
> 'enum' is applied in a list compatibles which is equivalent to 'oneOf'.
> Followed by 'const: fsl,imx27-pata' ensuring 1 enum and 1 const value
> matches.
>
> Should I use oneOf instead?
Why don't you respond to the comment?
Also, you ignored my other comments. No, that is not how it works. Go
and respond to each of them and answer how did you implement the
solution to my comment.
Best regards,
Krzysztof
prev parent reply other threads:[~2024-03-10 8:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-10 5:19 [PATCH v4] dt-bindings: imx-pata: Convert to dtschema Animesh Agarwal
2024-03-10 7:51 ` Krzysztof Kozlowski
[not found] ` <CAE3Oz80eZffUp9NCdkGYzt-uin8aevVx6w9Zxye6R1CURQjrhA@mail.gmail.com>
2024-03-10 8:11 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5572ba82-25ce-4216-a1e9-3a7def42cb28@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=animeshagarwal28@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlemoal@kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).