* Re: 2.6.24-rc4-mm1 and Very Slow PCMCIA Compact Flash
[not found] ` <1197068983.15428.29.camel@localhost>
@ 2007-12-07 23:22 ` Andrew Morton
2007-12-07 23:39 ` Zan Lynx
2007-12-08 5:01 ` Zan Lynx
0 siblings, 2 replies; 7+ messages in thread
From: Andrew Morton @ 2007-12-07 23:22 UTC (permalink / raw
To: Zan Lynx; +Cc: linux-kernel, linux-pcmcia, linux-ide
On Fri, 07 Dec 2007 23:09:43 +0000
Zan Lynx <zlynx@acm.org> wrote:
>
> On Fri, 2007-12-07 at 15:02 -0800, Andrew Morton wrote:
> > On Fri, 07 Dec 2007 20:38:24 +0000
> > Zan Lynx <zlynx@acm.org> wrote:
> >
> > > While I'm reporting problems I'll get this one out there.
> > >
> > > I normally use a USB-2 memory card reader but I also have a PCMCIA
> > > CompactFlash adapter that I use occasionally. During the MM series
> > > kernels 2.6.22 and 23 (I am pretty sure) this didn't work at all. I
> > > don't know about vanilla since I don't run that.
> > >
> > > Now with MM kernels 2.6.24 rc1-4 the PCMCIA adapter works again, but I
> > > only get read rates of 1.6 MB/s. When it used to work in 2.6.20 I got
> > > at least 16 MB/s. The card itself is capable of 30+ in the USB-2
> > > reader.
> > >
>
> > Are we talking about this?
> [cut]
> > > It might be that it auto-configures for PIO-0. I have no idea why it
> > > does that.
> > >
> > > Another interesting thing is that doing a dd to or from the card brings
> > > the rest of the system to a nearly complete halt. Interrupt problem?
> >
> > Where are you seeing the evidence that it autoconfigures for PIO-0?
>
> No, this:
> pccard: PCMCIA card inserted into slot 0
> cs: memory probe 0x50000000-0x57ffffff: excluding 0x50000000-0x57ffffff
> cs: memory probe 0xe0100000-0xe17fffff: excluding 0xe0100000-0xe026ffff 0xe03e0000-0xe082ffff 0xe0b10000-0xe10cffff
> pcmcia: registering new device pcmcia0.0
> scsi2 : pata_pcmcia
> ata3: PATA max PIO0 cmd 0x3100 ctl 0x310e irq 19
> ata3.00: CFA: LEXAR ATA FLASH, V2.00, max PIO6
> ata3.00: 8018640 sectors, multi 0: LBA
> ata3.00: configured for PIO0
> ata3.00: configured for PIO0
> ata3: EH complete
> isa bounce pool size: 16 pages
> scsi 2:0:0:0: Direct-Access ATA LEXAR ATA FLASH V2.0 PQ: 0 ANSI: 5
> sd 2:0:0:0: [sdb] 8018640 512-byte hardware sectors (4106 MB)
> sd 2:0:0:0: [sdb] Write Protect is off
> sd 2:0:0:0: [sdb] Mode Sense: 00 3a 00 00
> sd 2:0:0:0: [sdb] Write cache: disabled, read cache: enabled, doesn't support DPO or FUA
> sd 2:0:0:0: [sdb] 8018640 512-byte hardware sectors (4106 MB)
> sd 2:0:0:0: [sdb] Write Protect is off
> sd 2:0:0:0: [sdb] Mode Sense: 00 3a 00 00
> sd 2:0:0:0: [sdb] Write cache: disabled, read cache: enabled, doesn't support DPO or FUA sdb: sdb1
> sd 2:0:0:0: [sdb] Attached SCSI removable disk
>
> Specifically:
> ata3.00: configured for PIO0
> ata3.00: configured for PIO0
Oh, OK. Hopefully the ata guys can help out with this.
I don't know if it actually strictly a regression? Did libata ever support
that device in any earlier kernels?
Alan will be non-respnosive for a few weeks.
<looks>
Maybe pata_pcmcia-minor-cleanups-and-support-for-dual-channel-cards.patch?
Could you try a `patch -R' of the below?
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
Signed-off-by: Alan Cox <alan@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
drivers/ata/pata_pcmcia.c | 31 +++++++++++++++++--------------
1 file changed, 17 insertions(+), 14 deletions(-)
diff -puN drivers/ata/pata_pcmcia.c~pata_pcmcia-minor-cleanups-and-support-for-dual-channel-cards drivers/ata/pata_pcmcia.c
--- a/drivers/ata/pata_pcmcia.c~pata_pcmcia-minor-cleanups-and-support-for-dual-channel-cards
+++ a/drivers/ata/pata_pcmcia.c
@@ -42,7 +42,7 @@
#define DRV_NAME "pata_pcmcia"
-#define DRV_VERSION "0.3.2"
+#define DRV_VERSION "0.3.3"
/*
* Private data structure to glue stuff together
@@ -198,7 +198,6 @@ do { last_fn = (fn); if ((last_ret = (re
/**
* pcmcia_init_one - attach a PCMCIA interface
* @pdev: pcmcia device
- * @ops: operations for this device
*
* Register a PCMCIA IDE interface. Such interfaces are PIO 0 and
* shared IRQ.
@@ -217,9 +216,10 @@ static int pcmcia_init_one(struct pcmcia
cistpl_cftable_entry_t dflt;
} *stk = NULL;
cistpl_cftable_entry_t *cfg;
- int pass, last_ret = 0, last_fn = 0, is_kme = 0, ret = -ENOMEM;
+ int pass, last_ret = 0, last_fn = 0, is_kme = 0, ret = -ENOMEM, p;
unsigned long io_base, ctl_base;
void __iomem *io_addr, *ctl_addr;
+ int n_ports = 1;
struct ata_port_operations *ops = &pcmcia_port_ops;
@@ -348,7 +348,7 @@ next_entry:
/* FIXME: Could be more ports at base + 0x10 but we only deal with
one right now */
if (pdev->io.NumPorts1 >= 0x20)
- printk(KERN_WARNING DRV_NAME ": second channel not yet supported.\n");
+ n_ports = 2;
if (pdev->manf_id == 0x0097 && pdev->card_id == 0x1620)
ops = &pcmcia_8bit_port_ops;
@@ -357,20 +357,23 @@ next_entry:
* sane.
*/
ret = -ENOMEM;
- host = ata_host_alloc(&pdev->dev, 1);
+ host = ata_host_alloc(&pdev->dev, n_ports);
if (!host)
goto failed;
- ap = host->ports[0];
- ap->ops = ops;
- ap->pio_mask = 1; /* ISA so PIO 0 cycles */
- ap->flags |= ATA_FLAG_SLAVE_POSS;
- ap->ioaddr.cmd_addr = io_addr;
- ap->ioaddr.altstatus_addr = ctl_addr;
- ap->ioaddr.ctl_addr = ctl_addr;
- ata_std_ports(&ap->ioaddr);
+ for (p = 0; p < n_ports; p++) {
+ ap = host->ports[p];
- ata_port_desc(ap, "cmd 0x%lx ctl 0x%lx", io_base, ctl_base);
+ ap->ops = ops;
+ ap->pio_mask = 1; /* ISA so PIO 0 cycles */
+ ap->flags |= ATA_FLAG_SLAVE_POSS;
+ ap->ioaddr.cmd_addr = io_addr + 0x10 * p;
+ ap->ioaddr.altstatus_addr = ctl_addr + 0x10 * p;
+ ap->ioaddr.ctl_addr = ctl_addr + 0x10 * p;
+ ata_std_ports(&ap->ioaddr);
+
+ ata_port_desc(ap, "cmd 0x%lx ctl 0x%lx", io_base, ctl_base);
+ }
/* activate */
ret = ata_host_activate(host, pdev->irq.AssignedIRQ, ata_interrupt,
_
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: 2.6.24-rc4-mm1 and Very Slow PCMCIA Compact Flash
2007-12-07 23:22 ` Andrew Morton
@ 2007-12-07 23:39 ` Zan Lynx
2007-12-08 5:01 ` Zan Lynx
1 sibling, 0 replies; 7+ messages in thread
From: Zan Lynx @ 2007-12-07 23:39 UTC (permalink / raw
To: Andrew Morton; +Cc: linux-kernel, linux-pcmcia, linux-ide
[-- Attachment #1: Type: text/plain, Size: 1426 bytes --]
On Fri, 2007-12-07 at 15:22 -0800, Andrew Morton wrote:
> On Fri, 07 Dec 2007 23:09:43 +0000
> Zan Lynx <zlynx@acm.org> wrote:
>
> >
> > On Fri, 2007-12-07 at 15:02 -0800, Andrew Morton wrote:
> > > On Fri, 07 Dec 2007 20:38:24 +0000
> > > Zan Lynx <zlynx@acm.org> wrote:
> > >
> > > > While I'm reporting problems I'll get this one out there.
> > > >
> > > > I normally use a USB-2 memory card reader but I also have a PCMCIA
> > > > CompactFlash adapter that I use occasionally. During the MM series
> > > > kernels 2.6.22 and 23 (I am pretty sure) this didn't work at all. I
> > > > don't know about vanilla since I don't run that.
> > > >
> > > > Now with MM kernels 2.6.24 rc1-4 the PCMCIA adapter works again, but I
> > > > only get read rates of 1.6 MB/s. When it used to work in 2.6.20 I got
> > > > at least 16 MB/s. The card itself is capable of 30+ in the USB-2
> > > > reader.
> > > >
> >
[cut]
> Oh, OK. Hopefully the ata guys can help out with this.
>
> I don't know if it actually strictly a regression? Did libata ever support
> that device in any earlier kernels?
That could be why it didn't work for a few kernel versions. I
reconfigured for a libata-only system a while back. And, since I
usually use the USB-2 flash reader I didn't care much about the PCMCIA.
I will try reverting that patch later tonight, in a few hours.
--
Zan Lynx <zlynx@acm.org>
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: 2.6.24-rc4-mm1 and Very Slow PCMCIA Compact Flash
[not found] ` <fa.5knWxRyOEvQSAwZoz5fEa2Krvko@ifi.uio.no>
@ 2007-12-08 4:47 ` Robert Hancock
0 siblings, 0 replies; 7+ messages in thread
From: Robert Hancock @ 2007-12-08 4:47 UTC (permalink / raw
To: Zan Lynx; +Cc: Andrew Morton, linux-kernel, linux-pcmcia, linux-ide
Zan Lynx wrote:
> On Fri, 2007-12-07 at 15:22 -0800, Andrew Morton wrote:
>> On Fri, 07 Dec 2007 23:09:43 +0000
>> Zan Lynx <zlynx@acm.org> wrote:
>>
>>> On Fri, 2007-12-07 at 15:02 -0800, Andrew Morton wrote:
>>>> On Fri, 07 Dec 2007 20:38:24 +0000
>>>> Zan Lynx <zlynx@acm.org> wrote:
>>>>
>>>>> While I'm reporting problems I'll get this one out there.
>>>>>
>>>>> I normally use a USB-2 memory card reader but I also have a PCMCIA
>>>>> CompactFlash adapter that I use occasionally. During the MM series
>>>>> kernels 2.6.22 and 23 (I am pretty sure) this didn't work at all. I
>>>>> don't know about vanilla since I don't run that.
>>>>>
>>>>> Now with MM kernels 2.6.24 rc1-4 the PCMCIA adapter works again, but I
>>>>> only get read rates of 1.6 MB/s. When it used to work in 2.6.20 I got
>>>>> at least 16 MB/s. The card itself is capable of 30+ in the USB-2
>>>>> reader.
>>>>>
> [cut]
>> Oh, OK. Hopefully the ata guys can help out with this.
>>
>> I don't know if it actually strictly a regression? Did libata ever support
>> that device in any earlier kernels?
>
> That could be why it didn't work for a few kernel versions. I
> reconfigured for a libata-only system a while back. And, since I
> usually use the USB-2 flash reader I didn't care much about the PCMCIA.
>
> I will try reverting that patch later tonight, in a few hours.
It looks like pata_pcmcia is always PIO mode 0:
/**
* pcmcia_init_one - attach a PCMCIA interface
* @pdev: pcmcia device
*
* Register a PCMCIA IDE interface. Such interfaces are PIO 0 and
* shared IRQ.
*/
I assume that with old IDE this would use ide_cs.c, but I'm drawing a
blank on what modes that supports..
--
Robert Hancock Saskatoon, SK, Canada
To email, remove "nospam" from hancockr@nospamshaw.ca
Home Page: http://www.roberthancock.com/
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: 2.6.24-rc4-mm1 and Very Slow PCMCIA Compact Flash
2007-12-07 23:22 ` Andrew Morton
2007-12-07 23:39 ` Zan Lynx
@ 2007-12-08 5:01 ` Zan Lynx
2007-12-08 10:07 ` Andrew Morton
1 sibling, 1 reply; 7+ messages in thread
From: Zan Lynx @ 2007-12-08 5:01 UTC (permalink / raw
To: Andrew Morton; +Cc: linux-kernel, linux-pcmcia, linux-ide
[-- Attachment #1: Type: text/plain, Size: 1084 bytes --]
On Fri, 2007-12-07 at 15:22 -0800, Andrew Morton wrote:
> On Fri, 07 Dec 2007 23:09:43 +0000
> Zan Lynx <zlynx@acm.org> wrote:
[cut]
> > > > Now with MM kernels 2.6.24 rc1-4 the PCMCIA adapter works again, but I
> > > > only get read rates of 1.6 MB/s. When it used to work in 2.6.20 I got
> > > > at least 16 MB/s. The card itself is capable of 30+ in the USB-2
> > > > reader.
[cut]
> Maybe pata_pcmcia-minor-cleanups-and-support-for-dual-channel-cards.patch?
>
> Could you try a `patch -R' of the below?
>
>
> From: Alan Cox <alan@lxorguk.ukuu.org.uk>
>
> Signed-off-by: Alan Cox <alan@redhat.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
>
> drivers/ata/pata_pcmcia.c | 31 +++++++++++++++++--------------
> 1 file changed, 17 insertions(+), 14 deletions(-)
>
> diff -puN drivers/ata/pata_pcmcia.c~pata_pcmcia-minor-cleanups-and-support-for-dual-channel-cards drivers/ata/pata_pcmcia.c
[cut]
Nope, that did not change anything. It still detects as PIO0 and still
runs at 1.6 MB/s.
--
Zan Lynx <zlynx@acm.org>
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: 2.6.24-rc4-mm1 and Very Slow PCMCIA Compact Flash
2007-12-08 5:01 ` Zan Lynx
@ 2007-12-08 10:07 ` Andrew Morton
2007-12-09 3:02 ` Zan Lynx
0 siblings, 1 reply; 7+ messages in thread
From: Andrew Morton @ 2007-12-08 10:07 UTC (permalink / raw
To: Zan Lynx; +Cc: linux-kernel, linux-pcmcia, linux-ide, Alan Cox, Jeff Garzik
On Fri, 07 Dec 2007 22:01:33 -0700 Zan Lynx <zlynx@acm.org> wrote:
>
> On Fri, 2007-12-07 at 15:22 -0800, Andrew Morton wrote:
> > On Fri, 07 Dec 2007 23:09:43 +0000
> > Zan Lynx <zlynx@acm.org> wrote:
> [cut]
> > > > > Now with MM kernels 2.6.24 rc1-4 the PCMCIA adapter works again, but I
> > > > > only get read rates of 1.6 MB/s. When it used to work in 2.6.20 I got
> > > > > at least 16 MB/s. The card itself is capable of 30+ in the USB-2
> > > > > reader.
> [cut]
> > Maybe pata_pcmcia-minor-cleanups-and-support-for-dual-channel-cards.patch?
> >
> > Could you try a `patch -R' of the below?
> >
> >
> > From: Alan Cox <alan@lxorguk.ukuu.org.uk>
> >
> > Signed-off-by: Alan Cox <alan@redhat.com>
> > Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> > ---
> >
> > drivers/ata/pata_pcmcia.c | 31 +++++++++++++++++--------------
> > 1 file changed, 17 insertions(+), 14 deletions(-)
> >
> > diff -puN drivers/ata/pata_pcmcia.c~pata_pcmcia-minor-cleanups-and-support-for-dual-channel-cards drivers/ata/pata_pcmcia.c
> [cut]
>
> Nope, that did not change anything. It still detects as PIO0 and still
> runs at 1.6 MB/s.
argh. OK. And Linus's current tree is OK, yes?
In which case we should be OK for 2.6.24 and I guess we can hope like heck
that the dud patch doesn't leak into mainline. Hopefully Alan will get
some time to look into it before 2.6.25 opens.
<looks>
OK, there's a patch in Jeff's tree "pata_pcmcia: Add support for dumb 8bit
IDE emulations" which could be our guy.
I've uploaded two patches, against 2.6.24-rc4:
http://userweb.kernel.org/~akpm/zl.with.gz
origin.patch + git-libata-all.patch
http://userweb.kernel.org/~akpm/zl.without.gz
origin.patch + git-libata-all.patch - 5ddcddd4dfeb16a9509dad647f509828d6fee605
It would be great if you could test both. If zl.with is bad and zl.without
is good then we know that 5ddcddd4dfeb16a9509dad647f509828d6fee605 caused
this problem.
Thanks.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: 2.6.24-rc4-mm1 and Very Slow PCMCIA Compact Flash
2007-12-08 10:07 ` Andrew Morton
@ 2007-12-09 3:02 ` Zan Lynx
2007-12-09 4:04 ` Andrew Morton
0 siblings, 1 reply; 7+ messages in thread
From: Zan Lynx @ 2007-12-09 3:02 UTC (permalink / raw
To: Andrew Morton
Cc: linux-kernel, linux-pcmcia, linux-ide, Alan Cox, Jeff Garzik
[-- Attachment #1: Type: text/plain, Size: 1367 bytes --]
On Sat, 2007-12-08 at 02:07 -0800, Andrew Morton wrote:
> On Fri, 07 Dec 2007 22:01:33 -0700 Zan Lynx <zlynx@acm.org> wrote:
>
> >
> > On Fri, 2007-12-07 at 15:22 -0800, Andrew Morton wrote:
> > > On Fri, 07 Dec 2007 23:09:43 +0000
> > > Zan Lynx <zlynx@acm.org> wrote:
> > [cut]
> > > > > > Now with MM kernels 2.6.24 rc1-4 the PCMCIA adapter works again, but I
> > > > > > only get read rates of 1.6 MB/s. When it used to work in 2.6.20 I got
> > > > > > at least 16 MB/s. The card itself is capable of 30+ in the USB-2
> > > > > > reader.
[cut]
> argh. OK. And Linus's current tree is OK, yes?
>
> In which case we should be OK for 2.6.24 and I guess we can hope like heck
> that the dud patch doesn't leak into mainline. Hopefully Alan will get
> some time to look into it before 2.6.25 opens.
Linus' tree is also broken.
I tried a Linus 2.6.24-rc4 and it acts the same way, with a very slow
transfer rate.
I also tried 2.6.24-rc4 with the older not-libata PATA drivers and it is
broken. dmesg had a line about the CF card detected as hda,
but /sys/block did not have hda and /dev/hda did not function.
I will try the patches you mentioned, but I think I may also have to
work backward through kernel versions until I find the last one where
the PCMCIA hd{a,b,c,d,e} drivers worked.
--
Zan Lynx <zlynx@acm.org>
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: 2.6.24-rc4-mm1 and Very Slow PCMCIA Compact Flash
2007-12-09 3:02 ` Zan Lynx
@ 2007-12-09 4:04 ` Andrew Morton
0 siblings, 0 replies; 7+ messages in thread
From: Andrew Morton @ 2007-12-09 4:04 UTC (permalink / raw
To: Zan Lynx; +Cc: linux-kernel, linux-pcmcia, linux-ide, Alan Cox, Jeff Garzik
On Sat, 08 Dec 2007 20:02:54 -0700 Zan Lynx <zlynx@acm.org> wrote:
>
> On Sat, 2007-12-08 at 02:07 -0800, Andrew Morton wrote:
> > On Fri, 07 Dec 2007 22:01:33 -0700 Zan Lynx <zlynx@acm.org> wrote:
> >
> > >
> > > On Fri, 2007-12-07 at 15:22 -0800, Andrew Morton wrote:
> > > > On Fri, 07 Dec 2007 23:09:43 +0000
> > > > Zan Lynx <zlynx@acm.org> wrote:
> > > [cut]
> > > > > > > Now with MM kernels 2.6.24 rc1-4 the PCMCIA adapter works again, but I
> > > > > > > only get read rates of 1.6 MB/s. When it used to work in 2.6.20 I got
> > > > > > > at least 16 MB/s. The card itself is capable of 30+ in the USB-2
> > > > > > > reader.
> [cut]
> > argh. OK. And Linus's current tree is OK, yes?
> >
> > In which case we should be OK for 2.6.24 and I guess we can hope like heck
> > that the dud patch doesn't leak into mainline. Hopefully Alan will get
> > some time to look into it before 2.6.25 opens.
>
> Linus' tree is also broken.
>
> I tried a Linus 2.6.24-rc4 and it acts the same way, with a very slow
> transfer rate.
shit
> I also tried 2.6.24-rc4 with the older not-libata PATA drivers and it is
> broken.
squared.
> dmesg had a line about the CF card detected as hda,
> but /sys/block did not have hda and /dev/hda did not function.
But these drivers did work in earlier kernels, yes? 2.6.20 worked, but
we don't know about intervening kernels.
Can you tell us which version(s)?
> I will try the patches you mentioned
Yes, that won't tell use anything.
> but I think I may also have to
> work backward through kernel versions until I find the last one where
> the PCMCIA hd{a,b,c,d,e} drivers worked.
That would be great - a git-bisect is often ideal.
http://www.kernel.org/doc/local/git-quick.html has details.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2007-12-09 4:04 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <fa.9+cyQSoHqcg4p5BAdLi4beGvJ8E@ifi.uio.no>
[not found] ` <fa.es7DHARPOKbnzAqaEFBauYRpWjo@ifi.uio.no>
[not found] ` <fa.kwN53ZHLrpa2M5QIn+VR9hoaqjA@ifi.uio.no>
[not found] ` <fa.IgSJMFcov+qjLkhPpd1LhbCf93o@ifi.uio.no>
[not found] ` <fa.5knWxRyOEvQSAwZoz5fEa2Krvko@ifi.uio.no>
2007-12-08 4:47 ` 2.6.24-rc4-mm1 and Very Slow PCMCIA Compact Flash Robert Hancock
[not found] <1197059904.15428.15.camel@localhost>
[not found] ` <20071207150251.a0dbae23.akpm@linux-foundation.org>
[not found] ` <1197068983.15428.29.camel@localhost>
2007-12-07 23:22 ` Andrew Morton
2007-12-07 23:39 ` Zan Lynx
2007-12-08 5:01 ` Zan Lynx
2007-12-08 10:07 ` Andrew Morton
2007-12-09 3:02 ` Zan Lynx
2007-12-09 4:04 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).