From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Damien Le Moal <dlemoal@kernel.org>
Cc: Koba Ko <koba.ko@canonical.com>, linux-ide@vger.kernel.org
Subject: Re: [PATCH] ata: ahci: Add Intel Alder Lake-P AHCI controller to low power chipsets list
Date: Tue, 3 Oct 2023 07:36:21 +0300 [thread overview]
Message-ID: <20231003043621.GE3208943@black.fi.intel.com> (raw)
In-Reply-To: <42141dac-88eb-cbb7-0836-5fe51e35ac36@kernel.org>
Hi,
On Tue, Oct 03, 2023 at 09:49:20AM +0900, Damien Le Moal wrote:
> On 10/2/23 15:21, Mika Westerberg wrote:
> > On Tue, Sep 26, 2023 at 12:55:05PM +0800, Koba Ko wrote:
> >> On Mon, Sep 25, 2023 at 5:27 PM Damien Le Moal <dlemoal@kernel.org> wrote:
> >>>
> >>> On 2023/09/25 11:13, Mika Westerberg wrote:
> >>>> Hi,
> >>>>
> >>>> On Mon, Sep 25, 2023 at 11:09:01AM +0200, Damien Le Moal wrote:
> >>>>> On 2023/09/25 10:05, Mika Westerberg wrote:
> >>>>>> Intel Alder Lake-P AHCI controller needs to be added to the mobile
> >>>>>> chipsets list in order to have link power management enabled. Without
> >>>>>> this the CPU cannot enter lower power C-states making idle power
> >>>>>> consumption high.
> >>>>>>
> >>>>>> Cc: Koba Ko <koba.ko@canonical.com>
> >>>>>> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> >>>>>
> >>>>> Looks OK, but given that there is a tendency of the low power stuff to be buggy,
> >>>>> was this well tested ?
> >>>>
> >>>> Yes it was tested (Koba Cc'd can confirm this). We also confirmed from
> >>>> Intel AHCI folks that the ADL (and RPL) AHCI controllers fully support
> >>>> this configuration.
> >>
> >> I verified on an ADL platform with odd and disk devices and
> >> they work fine.
> >
> > Thanks!
> >
> > @Damien, just checking whether this fell through cracks because I do not
> > see it applied to libata.git next branches?
>
> Sorry about the delay. I was traveling and the suspend/resume fixes used all my
> bandwidth. Will queue this today. Do you want this for 6.7 or as a fix for 6.6 ?
> The latter is OK.
6.7 is fine, thanks!
next prev parent reply other threads:[~2023-10-03 4:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-25 8:05 [PATCH] ata: ahci: Add Intel Alder Lake-P AHCI controller to low power chipsets list Mika Westerberg
2023-09-25 9:09 ` Damien Le Moal
2023-09-25 9:13 ` Mika Westerberg
2023-09-25 9:27 ` Damien Le Moal
2023-09-26 4:55 ` Koba Ko
2023-10-02 6:21 ` Mika Westerberg
2023-10-03 0:49 ` Damien Le Moal
2023-10-03 4:36 ` Mika Westerberg [this message]
2023-10-03 1:00 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231003043621.GE3208943@black.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=dlemoal@kernel.org \
--cc=koba.ko@canonical.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).